Skip to content
This repository was archived by the owner on Mar 11, 2022. It is now read-only.

Increase CPU limit to 1 to support heavier template processing#361

Merged
Smiley73 merged 2 commits intomasterfrom
resources
Jul 23, 2020
Merged

Increase CPU limit to 1 to support heavier template processing#361
Smiley73 merged 2 commits intomasterfrom
resources

Conversation

@Smiley73
Copy link
Copy Markdown
Contributor

Description

Complex helm charts take forever to process. This change allows the pod to take up to 1 CPU (limit), but leaves the request at 200m.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Unit tests and e2e tests updated
  • Documentation updated

Copy link
Copy Markdown
Contributor

@sanbornick sanbornick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2020

Codecov Report

Merging #361 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   25.00%   25.00%           
=======================================
  Files           6        6           
  Lines         536      536           
=======================================
  Hits          134      134           
  Misses        373      373           
  Partials       29       29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d36e3e...717618e. Read the comment docs.

@vinny-sabatini
Copy link
Copy Markdown
Member

I'm ok with this, but something to keep in mind is the job request and limits are currently configurable without making the change to Eunomia directly.
Ref: https://github.com/KohlsTechnology/eunomia#job-templates

I believe there was talk of possibly making the requests/limits available in the CRD whenever we re-visit the definition, but the v1alpha2 discussion has been on hold at this point.

@Smiley73
Copy link
Copy Markdown
Contributor Author

Yeap. In v1alpha2 we want to actually move the resource setting into the CR, to be more flexible. Changing the template is a cluster-wide thing..

@Smiley73 Smiley73 merged commit a1c81ae into master Jul 23, 2020
@Smiley73 Smiley73 deleted the resources branch July 23, 2020 13:22
@seanmalloy seanmalloy added this to the v0.1.7 milestone Jul 23, 2020
@seanmalloy seanmalloy added the bug Something isn't working label Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

4 participants