Skip to content
This repository was archived by the owner on Mar 11, 2022. It is now read-only.

Replace shell script with hierarchy binary#380

Merged
Smiley73 merged 3 commits intomasterfrom
hierarchy
Jan 15, 2021
Merged

Replace shell script with hierarchy binary#380
Smiley73 merged 3 commits intomasterfrom
hierarchy

Conversation

@Smiley73
Copy link
Copy Markdown
Contributor

@Smiley73 Smiley73 commented Jan 11, 2021

Description

Replace the parameter processing shell script with a more solid golang program hierarchy, which has been released as a separate repo: https://github.com/KohlsTechnology/hierarchy
This allows also for better debugging of hierarchy issue.

Part of #79

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Unit tests and e2e tests updated
  • Documentation updated

@Smiley73 Smiley73 marked this pull request as ready for review January 11, 2021 22:11
Copy link
Copy Markdown

@25region 25region left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 11, 2021

Codecov Report

Merging #380 (06a1c41) into master (323ad32) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #380   +/-   ##
=======================================
  Coverage   23.52%   23.52%           
=======================================
  Files           6        6           
  Lines         493      493           
=======================================
  Hits          116      116           
  Misses        350      350           
  Partials       27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 323ad32...06a1c41. Read the comment docs.

MeganMoran
MeganMoran previously approved these changes Jan 13, 2021
@Smiley73 Smiley73 merged commit 5e31ff5 into master Jan 15, 2021
@Smiley73 Smiley73 deleted the hierarchy branch January 15, 2021 16:34
@seanmalloy seanmalloy added this to the v0.1.9 milestone Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

4 participants