zap-in/out feature#44
Merged
Merged
Conversation
ducquangkstn
force-pushed
the
example-zapin
branch
from
ba5c36b to
7548335
Compare
ducquangkstn
force-pushed
the
example-zapin
branch
2 times, most recently
from
78618a8 to
602c33e
Compare
ducquangkstn
force-pushed
the
example-zapin
branch
from
602c33e to
464c1fb
Compare
Anyhowclick
reviewed
Oct 28, 2021
| uint256 private constant PRECISION = 1e18; | ||
| uint256 internal constant Q112 = 2**112; | ||
|
|
||
| IDMMFactory public factory; |
| uint256 feeInPrecision, | ||
| uint256 userIn | ||
| ) internal pure returns (uint256) { | ||
| require(feeInPrecision < PRECISION, "invalid feeInPrecision"); |
There was a problem hiding this comment.
not necessary IMO, can trust the pool.
| } | ||
| uint256 inverseC = vIn.mul(userIn); | ||
| // numerator = sqrt(b^2 -4ac) - b | ||
| uint256 numerator = MathExt.sqrt(b.mul(b).add(inverseC.mul(4).mul(r) / PRECISION)).sub(b); |
There was a problem hiding this comment.
can do inverseC.mul(4*r) since r <= PRECISION.
Anyhowclick
approved these changes
Oct 29, 2021
Anyhowclick
approved these changes
Nov 1, 2021
manhlx3006
added a commit
that referenced
this pull request
Jun 14, 2022
* update env for matic, bsc and avax (#43) * zap-in/out feature (#44) * read function for zapOut (#46) * Fix bug calculate zapOutAmount (#47) * add rpc fantom (#45) * remove_dynamic_fee -> Done (#48) * remove_dynamic_fee -> Done * fix bugs and add deployment script * rename stuffs * remove unused var * move feeinPrecision to Factory and Rename DMM to KS * rename DMM to KS * remove dynamic fee, add fee options * fix deployment script * add modifier for checking fee setter * Add KSRouter, change feeOptions to public, remove getFinalFee * update hardhat config * fix hardhat config * add router test * rename dmmSwapCall to ksSwapCall, add ZapInV2 * fix test * rename deployKs to deployKyberSwap Co-authored-by: Jensen Tran <jensen@kyber.network> * Update minting fee formula for DAO (#49) * Add a new 0.008% fee option (#52) * Mutiply the fee options by 10 times * Add tests for changing BPS and add a new feeOption * Add FEE_UNITS * Update _mintFee func * Fix overflow in minting fee formula (#51) * Fix overflow mul div Co-authored-by: quang_neo <ducquang.kstn@gmail.com> Co-authored-by: Vu Tran <vutt94@gmail.com> Co-authored-by: Jensen Tran <jensen@kyber.network> Co-authored-by: Nguyen Minh Quan <30571817+minhquanym@users.noreply.github.com> Co-authored-by: Daniel Pham <daniel.pham765@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.