feat: add oracle price conditions (Chainlink + Pyth) #65
Open
minhtr09 wants to merge 1 commit into
Open
Conversation
minhtr09
force-pushed
the
conditional-swap-oracle
branch
from
25c4647 to
d26d596
Compare
thepluck
reviewed
Jun 19, 2026
Comment on lines
+89
to
+91
| priceIn < config.oracleIn.priceLimits >> 128 | ||
| || priceIn > uint128(config.oracleIn.priceLimits) | ||
| ) { |
Member
There was a problem hiding this comment.
should use packu128 for more concise code, or use unpack it clearly
| } | ||
|
|
||
| // PYTH: price = pyth.price * 10^(expo + 18) | ||
| uint256 age = maxStaleness == 0 ? type(uint256).max : maxStaleness; |
Member
There was a problem hiding this comment.
shouldnt allow zero max staleness
Comment on lines
+52
to
+62
| if (updateData.length == 0) return; | ||
| address pythIn = | ||
| config.oracleIn.oracleType == OracleType.PYTH ? config.oracleIn.source : address(0); | ||
| address pythOut = | ||
| config.oracleOut.oracleType == OracleType.PYTH ? config.oracleOut.source : address(0); | ||
| if (pythIn != address(0)) { | ||
| _pythUpdate(pythIn, updateData); | ||
| } | ||
| if (pythOut != address(0) && pythOut != pythIn) { | ||
| _pythUpdate(pythOut, updateData); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.