Upgrading to 3.7.0

[unematiii]

I'm having a bit of trouble upgrading to latest (after esm/cjs changes), some of my tests (ts-jest) now fail with:

 /Users/mati/xxx/node_modules/fastify-decorators/testing/index.js:8
    export { configureControllerTest, } from './configure-controller-test.js';
    ^^^^^^

    SyntaxError: Unexpected token 'export'

    > 1 | import { configureServiceTest } from 'fastify-decorators/testing';

Linting tests also fails:

/Users/mati/xxx/tests/unit/yyyy/services/zzz.service.spec.ts
  1:1   error    Resolve error: Cannot find module '/Users/mati/xxx/node_modules/fastify-decorators/testing/index.cjs'
    at createEsmNotFoundErr (internal/modules/cjs/loader.js:907:15)
    at finalizeEsmResolution (internal/modules/cjs/loader.js:900:15)
    at resolveExports (internal/modules/cjs/loader.js:432:14)
    at Function.Module._findPath (internal/modules/cjs/loader.js:472:31)
    at findModulePath (/Users/mati/xxx/node_modules/eslint-import-resolver-alias/index.js:99:27)
    at Object.exports.resolve (/Users/mati/xxx/node_modules/eslint-import-resolver-alias/index.js:75:10)
    at v2 (/Users/mati/xxx/node_modules/eslint-module-utils/resolve.js:117:23)
    at withResolver (/Users/mati/xxx/node_modules/eslint-module-utils/resolve.js:122:16)
    at fullResolve (/Users/mati/xxx/node_modules/eslint-module-utils/resolve.js:139:22)
    at relative (/Users/mati/xxx/node_modules/eslint-module-utils/resolve.js:84:10)  import/namespace

I'm not entirely sure what needs to be changed here... Any help will be appreciated.

---

Update:

Might not be related, but in package.json I can see

    "./testing": {
      "import": "./testing/index.js",
      "require": "./testing/index.cjs"
    }

however, there is no index.cjs present...

[L2jLiga]

My bad, forgot to add fastify-decorators/testing to rollup config, published v3.7.1

[unematiii]

Thanks! That removed the linting errors, but my tests still fail.

[unematiii]

Okay managed to get rid of SyntaxError: Unexpected token 'export' error with custom ts-config ("allowJs": true, "module": "ESNext") and using transform and transformIgnorePatterns in jest config. Hovever, now all async service tests fail with:

TypeError: Cannot read property 'then' of undefined

      44 |   describe('initializer', () => {
      45 |     it('initializes db client and attaches logger functions for knex `query-response` and `query-error` events', async () => {
    > 46 |       const service = await configureServiceTest({
         |                             ^
      47 |         service: DatabaseService,
      48 |       });

[unematiii]

Looks like in node_modules/fastify-decorators/testing/configure-service-test.js, at following lines

if (promise == null)
                    promise = hasAsyncInitializer(service) ? readyMap.get(service).then(() => target) : Promise.resolve(target);

hasAsyncInitializer returns true but next call to readyMap.get(service) evaluates to undefined which results in error...

[L2jLiga]

Are you building ESM?

[L2jLiga]

I weren't able to make work ESM+TS+Jest so in one of my projects I switched to tap and mocha in ESM example

[L2jLiga]

Hope in Jest 27 it will work

[unematiii]

I am building for commonjs and everything works, except for tests. So I created a separate tsconfig for tests:

"compilerOptions": {
    "lib": [
        "es2019",
        "es2020.promise",
        "es2020.bigint",
        "es2020.string"
    ],
    "module": "esnext",
    "target": "es2019",
    "strict": true,
    "esModuleInterop": true,
    "skipLibCheck": true,
    "forceConsistentCasingInFileNames": true,
    "baseUrl": "./",
    "paths": {
        "@/*": [
            "src/*"
        ]
    },
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "noImplicitAny": true,
    "noUnusedLocals": true,
    "strictNullChecks": true,
    "allowJs": true,
    "moduleResolution": "node"
},

Now I just realized, that while configureServiceTest is loaded from ESM module ('.js'), service INITIALIZER and CREATOR are assigned in decorators/service.cjs and decorators/initializer.cjs respectively, hence, different instance of readyMap is used - I have no idea why....

Following apporach doesn't seem to work either:

jest.config.ts:

preset: 'ts-jest/presets/js-with-ts',
transform: {
  '^.+\\.(j|t)s?$': 'ts-jest',
},
transformIgnorePatterns: ['<rootDir>/node_modules/(?!fastify-decorators)'],

tsconfig.spec.json:

{
  "compilerOptions": {
        "lib": [
            "es2019",
            "es2020.promise",
            "es2020.bigint",
            "es2020.string"
        ],
        "module": "commonjs",
        "target": "es2019",
        "strict": true,
        "esModuleInterop": true,
        "skipLibCheck": true,
        "forceConsistentCasingInFileNames": true,
        "baseUrl": "./",
        "paths": {
            "@/*": [
                "src/*"
            ]
        },
        "experimentalDecorators": true,
        "emitDecoratorMetadata": true,
        "noImplicitAny": true,
        "noUnusedLocals": true,
        "strictNullChecks": true,
        "allowJs": true
    }
}

[unematiii]

I weren't able to make work ESM+TS+Jest so in one of my projects I switched to tap and mocha in ESM example

Can you explain further what are the obstacles here?

[L2jLiga]

I'm going to create and investigate sample repository tomorrow, for a moment you can try to build your application and tests and then run tests on transpiled code or switch to another test framework (I think you would like avoid it)

[unematiii]

I'm going to create and investigate sample repository tomorrow, for a moment you can try to build your application and tests and then run tests on transpiled code or switch to another test framework (I think you would like avoid it)

Thanks! Actually building tests and testing against dist might make sence. I can't afford to switch to another testing FW atm...

[unematiii]

Update: I ended up reverting all the changes and kept my original ts-config (module: 'commonjs') by simply hard-mapping js to cjs in jest.config.ts:

moduleNameMapper: {
  // ...
  'fastify-decorators/testing': 'fastify-decorators/testing/index.cjs',
  // ...
},

[L2jLiga]

Very nice! I think this should be noticed here

[L2jLiga]

Here's PR about adding support for TS + ESM: jestjs/jest#10823, it's already merged but I didn't managed how to make it work yet, for a while I added section to documentation about configuring Jest