Replace gson.tojson with Parcelable implementation#1124
Merged
Conversation
MV-GH
changed the title
dessalines
approved these changes
Aug 3, 2023
dessalines
requested changes
Aug 3, 2023
dessalines
left a comment
dessalines
left a comment
Member
There was a problem hiding this comment.
NM just tested, this crashes for some reason.
Collaborator
Author
|
Do you still have the stack trace? |
Collaborator
Author
|
Cuz I cant reproduce this error, what action did you do? |
dessalines
approved these changes
Aug 4, 2023
dessalines
left a comment
dessalines
left a comment
Member
There was a problem hiding this comment.
My bad. I just tried this after merging from main again, and couldn't replicate the error. It was crashing on startup. Anyways we can merge this after it passes CI, we'll pretty quickly know if it happens again.
Collaborator
Author
|
These code changes shouldn't even trigger on startup. Probably was a room error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also replaced the consume.Return & addReturn.
I tried to get
takeDepsFromRootto be one function but that did not work@nahwneeth what do you think?
Fixes #1061