Revamped BottomBar to match MD3#567
Merged
Merged
Conversation
Signed-off-by: IronVeil <git@ironveil.cloud>
Contributor
|
Run |
Signed-off-by: IronVeil <git@ironveil.cloud>
Contributor
Author
Done, should all be fine now |
dessalines
approved these changes
Jun 13, 2023
dessalines
left a comment
dessalines
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks!
Resolve that one conflict and we'll get this merged.
Member
|
Still failing lint, run format again. |
Signed-off-by: IronVeil <git@ironveil.cloud>
Contributor
Author
|
Done, also moved the labels to stringResources so that they can be localised. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I have added more to the navigation bar to make it fit in with Material 3. This includes changing it from BottomAppBar to NavigationBar, and adding labels to each element.
I have also renamed community lists to search as it doesn't fit on a label, and search seems more appropriate.
Thanks, IV.