Skip to content

fix: Comment replies icon appears in profile #533#726

Merged
dessalines merged 4 commits into
LemmyNet:mainfrom
LufyCZ:fix_comment_replies_icon-#533
Jun 20, 2023
Merged

fix: Comment replies icon appears in profile #533#726
dessalines merged 4 commits into
LemmyNet:mainfrom
LufyCZ:fix_comment_replies_icon-#533

Conversation

@LufyCZ

@LufyCZ LufyCZ commented Jun 17, 2023

Copy link
Copy Markdown
Contributor

@dessalines dessalines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a merge from main, but also I don't understand the point of this. We recently allowed replying to your own comment, so that should be okay.

@LufyCZ

LufyCZ commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

This needs a merge from main, but also I don't understand the point of this. We recently allowed replying to your own comment, so that should be okay.

Currently, when you click on a comment from the profile section, when it has replies, it "collapses" like it would in the post section.

Now why that's an issue - when you collapse a comment, it shows a number of how many comments were collapsed. The comments don't show and aren't collapsed in the profile section, but the number of "collapsed" comments still shows.

Can get you a quick vid of the issue if needed.

It's not that big of an issue, but refactoring it like this allows for custom comment onClicks depending on where the component's used. Allowing for a simple implenentation of things like this #745

@dessalines

Copy link
Copy Markdown
Member

Ah I see what you're saying, gotcha. The click in that case should really show the context (same for inbox)

@dessalines dessalines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Comment thread app/src/main/java/com/jerboa/ui/components/comment/CommentNode.kt
@dessalines dessalines enabled auto-merge (squash) June 20, 2023 14:09
@dessalines dessalines merged commit be7b591 into LemmyNet:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants