Skip to content

Added close on click functionality to ImageViewerDialog. Solves #736#738

Merged
dessalines merged 3 commits into
LemmyNet:mainfrom
sockenklaus:736_close_image_viewer_on_tap
Jun 19, 2023
Merged

Added close on click functionality to ImageViewerDialog. Solves #736#738
dessalines merged 3 commits into
LemmyNet:mainfrom
sockenklaus:736_close_image_viewer_on_tap

Conversation

@sockenklaus

@sockenklaus sockenklaus commented Jun 18, 2023

Copy link
Copy Markdown

This closes #736

@dessalines dessalines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dessalines dessalines merged commit ba8397c into LemmyNet:main Jun 19, 2023
@sockenklaus sockenklaus deleted the 736_close_image_viewer_on_tap branch June 19, 2023 13:10
@pipe01

pipe01 commented Jun 27, 2023

Copy link
Copy Markdown
Contributor

This means that you can no longer tap to toggle the top bar, double tap to quickly zoom in or double tap and drag do zoom in or out, and it adds an ugly white overlay on tap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add action to tap to close image viewer

4 participants