Copy post and comment information to clipboard#850
Merged
twizmwazin merged 5 commits intoJun 23, 2023
Conversation
Collaborator
|
The three composables are almost the change them into a generic something like MyThumbnailCopy and pass the differences as arguments |
Contributor
Author
|
Comments don't have thumbnails, but I agree the common code should be contained in a method or class |
twizmwazin
suggested changes
Jun 23, 2023
twizmwazin
left a comment
Contributor
There was a problem hiding this comment.
One other thing, I'm noticing that the dialog is not being dismissed after selecting the added options. If you're feeling up to it, maybe add in the option to copy post text as well while we're here.
Contributor
Author
|
I just realized there's an Utils file, so I used that to place the new function. |
twizmwazin
approved these changes
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to copy the thumbnail url of a post if available, and copy a comment made to a post.