Skip to content

Add local crash tracking and viewing#945

Merged
MV-GH merged 5 commits into
LemmyNet:mainfrom
camporter:crash_tracking
Jul 12, 2023
Merged

Add local crash tracking and viewing#945
MV-GH merged 5 commits into
LemmyNet:mainfrom
camporter:crash_tracking

Conversation

@camporter

@camporter camporter commented Jul 2, 2023

Copy link
Copy Markdown
Contributor

Uses https://github.com/FunkyMuse/Crashy to save and access previous app crashes.

Screen_recording_20230711_000849.mp4

@camporter

Copy link
Copy Markdown
Contributor Author

I've left this in draft just to gauge the feelings behind local crash reporting. There was an issue discussing this and other solutions, but I can't seem to find it now.

@MV-GH

MV-GH commented Jul 7, 2023

Copy link
Copy Markdown
Collaborator

I think you mean #681. This pretty great but I'm guessing if you crash at startup this won't be useable?

@camporter

Copy link
Copy Markdown
Contributor Author

Right. Start up crashes should still be recorded depending on how bad they are, but won't be accessible to a user without doing something to avoid the crash.

This avoids transmitting crashes somewhere that users might not like or trust, and is at least better than no way (besides system crash reporting) to get crashes to report.

@dessalines dessalines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to have this, thanks. Fix conflicts then we can test.

@camporter

Copy link
Copy Markdown
Contributor Author

👍 rebased

@camporter camporter marked this pull request as ready for review July 11, 2023 05:13
Comment thread app/src/main/res/values/strings.xml Outdated
<string name="community_sortBy">Sort by</string>
<string name="community_subscribe">Subscribe</string>
<string name="community_users_month">%1$s users / month</string>
<string name="crashes">Crashes</string>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Crash logs", "All crash logs deleted", "Copy crash log" and "Delete all crash logs"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's much easier to read, changed 👍

@dessalines dessalines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this, and it seems to work. Thx!

@MV-GH MV-GH enabled auto-merge (squash) July 12, 2023 16:01
@MV-GH MV-GH merged commit 7072258 into LemmyNet:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants