Implement federated bans (fixes #1298)#1553
Merged
dessalines merged 7 commits intomainfrom Apr 9, 2021
Merged
Conversation
Member
Author
|
This is ready to review/merge. Everything works fine during manual testing, including ban/unban actions from remote community mods. The changes are fully backwards compatible, so this can be backported to stable. |
dessalines
reviewed
Apr 9, 2021
Member
dessalines
left a comment
dessalines
left a comment
There was a problem hiding this comment.
Looks good, but the tests are failing.
| blocked_user: Person, | ||
| context: &LemmyContext, | ||
| ) -> Result<(), LemmyError> { | ||
| let mut block = Block::new(actor.actor_id(), blocked_user.actor_id()); |
Member
There was a problem hiding this comment.
Makes sense, never realized a ban is basically a community blocking a user. This might be usable for the eventual user <-> user blocks too.
Member
Author
|
Fixed. |
dessalines
approved these changes
Apr 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.