This repository was archived by the owner on Dec 2, 2024. It is now read-only.
Refactor open() and close() to mostly bypass levelup#79
Closed
Refactor open() and close() to mostly bypass levelup#79
Conversation
vweevers
commented
Sep 30, 2019
Member
Author
|
To simplify, maybe we should say that a user must manage the open state of a db outside of subleveldown. Meaning:
|
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 1, 2019
Member
😆 |
cbd6b9a to
5119ac0
Compare
Merged
This comment has been minimized.
This comment has been minimized.
…bstract-leveldown < 2.4.0
0033a71 to
a69ba5d
Compare
Member
Author
|
Alternative strategy:
|
Member
Author
|
In other words, the input db must open itself (or once closed by the user, be explicitly reopened by the user) because sublevels shouldn't concern themselves with (the state of) the rest of the db. Closing this PR, I don't like it. Will explore the alternative strategy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60, closes #77, closes #78, and opens up the possibility to add a manifest.
I was sitting around thinking "how can i make subleveldown more complicated" and this PR is the result.