fix: add automatic update checks#19
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an automatic (throttled) update-notice mechanism to the CLI so interactive human runs can be informed about newer GitHub Releases without polluting machine-readable output, and provides documentation + tests for the behavior.
Changes:
- Introduces a cached/throttled
check_for_update_notice()flow that records state in an on-disk JSON cache and supports disabling viaATLASSIAN_DISABLE_UPDATE_CHECK. - Hooks the update notice into the Typer root callback for interactive sessions (stderr TTY) while skipping machine output modes and the
updatecommand group. - Adds README documentation and regression tests covering notice, throttling, disabling, and failure paths.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/atlassian_cli/update.py |
Implements the update-check state file, throttling logic, and notice formatting/decision logic. |
src/atlassian_cli/cli.py |
Emits the update notice for interactive, non-machine output commands (excluding update). |
tests/test_update.py |
Adds tests for update notice behavior + CLI emission rules. |
README.md |
Documents the automatic update check behavior and disable flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ccee61a to
baee014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan