Skip to content
This repository was archived by the owner on Sep 5, 2020. It is now read-only.

Update README.MD list of devices#7

Open
MagicFab wants to merge 1 commit intoLimych:masterfrom
MagicFab:patch-1
Open

Update README.MD list of devices#7
MagicFab wants to merge 1 commit intoLimych:masterfrom
MagicFab:patch-1

Conversation

@MagicFab
Copy link
Copy Markdown

Re-formatted as list to start adding links to individual products, added link to Cobblestone

Re-formatted as list to start adding links to individual products, added link to Cobblestone
@MagicFab MagicFab requested a review from Limych as a code owner October 16, 2019 01:15
@Limych
Copy link
Copy Markdown
Owner

Limych commented Oct 16, 2019

Thanks for your help to the project.

I understand your logic, but I do not think it is correct for the purposes of the project.

As I see it, usually people will find integration AFTER they purchase any device supported by this integration. That means they will no longer need links to manufacturers' websites.

In addition, the list you created is very long, which makes it difficult to read the documentation. I initially made the list on one line precisely for its compactness.

But we can’t remove the list from the documentation either. otherwise, the integration will not be in search engines when searching by device name.

@MagicFab
Copy link
Copy Markdown
Author

Thanks for the feedback. Maybe the list can be moved to the end ?
I already have all URLs for products that are still relevant. It took a long time to research this, the goal is to save that time to others, specially to easily find which devices are speakers, which are multi-room Wifi adapters, etc.
I am interested in updating this list every few weeks as I find more information.

@Limych
Copy link
Copy Markdown
Owner

Limych commented Oct 17, 2019

Move the list to the end, I think, is wrong. It is an essential part of the introduction and contributes to a more accurate understanding of the possibilities of this integration for the user.

I propose to make something between your original plan and what was done by me.

The format of the list should be left as is — all items in one line, the names of the companies with emphasis — but the list itself should be modified. We can make links from device names to their description pages. Plus, from a single list, thats possible to break it to groups: speakers, multi-room Wifi adapters, etc.

It turns out something like this on the markup:

* Speakers: **August** (WS300G), **Auna** (Intelligence Tube), …
* Multi-room Wi-Fi adapters: **Bauhn** (SoundMax 5), **MÜZO** ([Cobblestone](https://www.arylic.com/products/muzo-cobblestone-wifi-pre-amp-with-airplay-dlna-spotify-connect)), …
  • Speakers: August (WS300G), Auna (Intelligence Tube), …
  • Multi-room Wi-Fi adapters: Bauhn (SoundMax 5), MÜZO (Cobblestone), …

@MagicFab
Copy link
Copy Markdown
Author

OK, that sounds great. You can reject this PR, I will make another one. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants