Skip to content

add a test script for postgres#118

Open
rishabhBudhouliya wants to merge 2 commits intomainfrom
test/postgres
Open

add a test script for postgres#118
rishabhBudhouliya wants to merge 2 commits intomainfrom
test/postgres

Conversation

@rishabhBudhouliya
Copy link
Copy Markdown
Contributor

@rishabhBudhouliya rishabhBudhouliya commented Mar 4, 2026

This test script performs three functions:

  • check if postgres binaries exist in lindfs/bin
  • validate if postgres --version works or not
  • validate if postgres --help runs or not

I've manually tested the script and it seems to be working as stated.

Note: This PR depends on #107 to be approved and merged first.

@rishabhBudhouliya rishabhBudhouliya changed the title add a test script for sanity runs of postgres app on lind-wasm add a test script for postgres Mar 4, 2026
@vidyalakshmir
Copy link
Copy Markdown
Contributor

@rishabhBudhouliya This looks good and can be merged. Testing functionality can be done separately through a different script then?

@vidyalakshmir
Copy link
Copy Markdown
Contributor

@rishabhBudhouliya Also where is FINDINGS.md. Saw it in the comments in test.sh

Comment thread postgres/test.sh Outdated
# and can handle basic invocations (--version, --help).
#
# Functional tests (initdb -D, postgres --single) are not yet possible
# due to missing lind-wasm syscalls — see postgres/FINDINGS.md for details.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, this was for me -- not supposed to commit it to remote.

@rishabhBudhouliya
Copy link
Copy Markdown
Contributor Author

rishabhBudhouliya commented Mar 4, 2026

@vidyalakshmir that comment about FINDINGS.md was for me, I've removed it. The findings have been updated on the issue itself: #114 (comment)

I haven't yet investigated why we're having these failures but I wanted to understand the scope of this task. In the issue it says we are fine with test files that do sanity of compilation and placement of binaries in lindfs.
Is the task also to ensure functionalities of the said app work as well?

@rishabhBudhouliya
Copy link
Copy Markdown
Contributor Author

@rishabhBudhouliya This looks good and can be merged. Testing functionality can be done separately through a different script then?

Got it. We'd have to #107 get this merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants