You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Can you follow the directory structure of imfs_grate and geteuid_grate as well? i.e. place all the .c/.h files in src/, and add a compile script which will place the .wasm/.cwasm files in output/?
Does this convert arguments to strings as well or is that a TODO?
Can you follow the directory structure of imfs_grate and geteuid_grate as well? i.e. place all the .c/.h files in src/, and add a compile script which will place the .wasm/.cwasm files in output/?
Latest version of lind_compile has a flag that facilitates compilation of the grate and copies pre-compiled binary to lindfs, which i think is pretty streamlined.
Does this convert arguments to strings as well or is that a TODO?
Yes, it does convert syscall arguments with type ARG_STR into a string.
Let me know when all the changes are in so that I can more thoroughly review the code. Housekeeping comments:
Latest version of lind_compile has a flag that facilitates compilation of the grate and copies pre-compiled binary to lindfs, which i think is pretty streamlined.
The compile_grate.sh script can simply be invoking lind_compile --compile-grate, but we should have that script.
The only information about how to compile this in this PR description.
This helps with automation, such as for the benchmark tests. Right now I would have to guess which order I should supply these .c files to lind_compile and the output binary will be named differently based on what order I pick.
This is more or less standard practice for standalone projects to have a Makefile-esque thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds C strace grate. I have currently disabled handler registration for
execandclonesyscalls.Compile using:
lind_compile --compile-grate strace_grate.c strace.c