Merged
Conversation
Yaxuan-w
reviewed
Mar 20, 2026
| @@ -0,0 +1,201 @@ | |||
| # This file is automatically @generated by Cargo. | |||
drapl0n
reviewed
Mar 20, 2026
| static void test_mkdir(void) { | ||
| printf("\n[test_mkdir]\n"); | ||
|
|
||
| int ret = mkdir("/mydir", 0755); |
Contributor
There was a problem hiding this comment.
header file sys/stat.h is required for mkdir() call
Contributor
There was a problem hiding this comment.
Tested this, added comments here but also opened a PR which merges into this branch with the fixes for the issues I stated.
Take a look at that PR here: #50
- Additional work is needed for fork/exec as I've mentioned in these comments, specially vis-a-vis fdtables usage.
- There are bugs in the fork/exec handlers
- We need some PRs to go into Lind for other behaviours (Lind-Project/lind-wasm#967 & Lind-Project/lind-wasm#970)
- There were some minor error handling and quality of life changes for imfs/
- Looks like these files aren't properly linted? A lot of the diff on the new PR is just cargo fmt fixes.
imfs-rs fixes + new tests
24 tasks
Contributor
|
Fixed behaviour around fork and updated the tests. Re-requesting reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How it works
fdtables integration:
Filesystem:
Registered syscalls: open, close, read, write, lseek, fcntl, unlink, pread, pwrite, fork, exec
Files
examples/imfs-grate-rs/
Cargo.toml
src/
main.rs - GrateBuilder setup, preload support
handlers.rs - 11 extern "C" syscall handlers
imfs/
mod.rs - ImfsState, fs operations, chunk read/write, path resolution
node.rs - Node, NodeType, Chunk, DirEntry types
test/
imfs_test.c - C test binary (11 tests)