Merged
Conversation
Contributor
|
I'm guessing the crypto stuff is ported from somewhere. Is it libcrypt? We should probably just compile that separately from the apps repo I think |
rennergade
reviewed
Mar 31, 2026
rennergade
reviewed
Mar 31, 2026
rennergade
reviewed
Mar 31, 2026
rennergade
requested changes
Mar 31, 2026
Contributor
rennergade
left a comment
rennergade
left a comment
There was a problem hiding this comment.
Looks really good now. Added a few issues.
Closed
Member
Author
|
Will remove source code of ed21559 in this PR once both source code PR and build PR (will put up after source PR being merged) are merged. |
rennergade
reviewed
Apr 11, 2026
rennergade
reviewed
Apr 11, 2026
rennergade
approved these changes
Apr 11, 2026
Contributor
rennergade
left a comment
rennergade
left a comment
There was a problem hiding this comment.
two minor changes but I think this can be merged after
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.