Open
Conversation
Contributor
End-to-End Test ReportTest PreviewUnified Test Report grate harness
Cases
wasm harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
|
a couple of more dlopen related tests are added to main, could you take a look and try to make them compatible with the pipeline as well? feel free to reorganize the file structure in dylink tests if you want (e.g. split library file and main module file into seperate directory) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Dedicated
dlopenSmoke Validation to Existing E2E Test FlowWhy
We need explicit CI signal for dynamic library loading via
dlopen, while keeping the current harness architecture stable.The existing unit harness (
scripts/test_runner.py+scripts/harnesses/wasmtestreport.py) is still the main path, butdlopenpositive-path validation needs a two-phase compile sequence:--compile-libraryWhat Changed
scripts/dlopen_smoke_test.shmake testcommand chainreports/dlopen.jsonas a normal report artifact consumed by existing report checksHow the
dlopenSmoke Test WorksThe script executes four explicit checks and logs each one in JSON:
compile_librarycompile_mainrun_mainverify_output_substringFor each check, the script records:
namestatus(pass,fail, orskipped)commandoutput(captured stdout/stderr or skip reason)At the end it writes a summary:
summary.totalsummary.passedsummary.failedsummary.skippedTop-level status is reflected as:
status: pass|failnumber_of_failures: <failed count>Expected Success Condition
The smoke test is considered successful when:
Hello, main module! (from shared library)How It Folds into Existing
make testThis is integrated directly into the current
Makefiletesttarget sequence:python3 ./scripts/test_runner.py --export-report report.html)./scripts/dlopen_smoke_test.shscripts/check_reports.pyThis keeps behavior consistent with current E2E flow and avoids creating a separate CI path.
CI / Buildx Behavior
No workflow-level changes are required.
The normal E2E build command still works and now includes the new signal:
docker buildx build \ --platform linux/amd64 \ --file Docker/Dockerfile.e2e \ --tag e2e:latest \ --output type=local,dest=test-reports \ .Artifacts now include:
test-reports/reports/dlopen.jsonwasm.json,grates.json,report.html, etc.)