Open
Conversation
- Add static_tests category under tests/unit-tests/ with deterministic tests for fork, threads, and TLS to cover static WASM builds - Add statictestreport harness that runs wasmtestreport with --static and -pthread flags; results are included in the combined report.html without generating a separate artifact file - Add --static flag to wasmtestreport.py (inserts --static before the source file in lind_compile invocations) - Refactor test_runner.py so harnesses can contribute HTML to the combined report.html purely in memory, without requiring a separate html_filename artifact
Yaxuan-w
reviewed
Apr 15, 2026
Member
There was a problem hiding this comment.
Can we rename this file to dynamic related?
Contributor
Author
There was a problem hiding this comment.
this test runner invokes lind_compile with no additional argument, so this is essentially doing the test with default configuration in lind_compile. If default configuration in lind_compile is changed, then what this test runner is testing is also changed. Therefore, I'd like to keep the name
Contributor
End-to-End Test ReportTest PreviewUnified Test Report grate harness
Cases
static harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
wasm harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
tashabits
reviewed
Apr 15, 2026
| # --allow-pre-compiled : use .cwasm AOT binaries (consistent with dynamic harness) | ||
| # --compile-flags -pthread -lpthread : link pthread for thread/TLS tests | ||
| _STATIC_HARNESS_ARGS = [ | ||
| "--run", "static_tests", |
Member
There was a problem hiding this comment.
Since this harness now owns static_tests, should we also exclude static_tests from the default wasmtestreport run? As written, I believe the normal wasm harness still discovers all tests/unit-tests/**/*.c, so these tests look like they’ll run once as dynamic-build tests and again here as static-build tests. Would it make sense to add a small guard near the existing if module_name == "wasmtestreport": block, perhaps appending a flag?
Contributor
Author
There was a problem hiding this comment.
just resolved this, could you take a look again
Exclude static_tests from the wasmtestreport harness so they are not run twice as dynamic-build tests (they are owned by statictestreport). Also handle PermissionError in wasmtestreport's testfiles cleanup so a permission issue on lindfs/testfiles does not crash the subprocess and cause statictestreport to abort before writing the combined report.
Contributor
End-to-End Test ReportTest PreviewUnified Test Report grate harness
Cases
static harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
wasm harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1040