lind-perf: baseline changes. add lind-perf crates, include basic feature plumbing.#846
Open
stupendoussuperpowers wants to merge 14 commits intomainfrom
Open
lind-perf: baseline changes. add lind-perf crates, include basic feature plumbing.#846stupendoussuperpowers wants to merge 14 commits intomainfrom
lind-perf: baseline changes. add lind-perf crates, include basic feature plumbing.#846stupendoussuperpowers wants to merge 14 commits intomainfrom
Conversation
- Add lind-perf library - Patch --features lind_perf to lind-boot, rawposix, threei, wasmtime-lind-common - Add basic timers in lind-boot::trampoline - Add --perf=[<clock|tsc>] UI flag with proper handling
This was referenced Feb 27, 2026
Contributor
End-to-End Test ReportTest PreviewUnified Test Report grate harness
Cases
wasm harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
rennergade
reviewed
Feb 28, 2026
rennergade
reviewed
Feb 28, 2026
rennergade
reviewed
Feb 28, 2026
rennergade
reviewed
Feb 28, 2026
Contributor
rennergade
left a comment
rennergade
left a comment
There was a problem hiding this comment.
a few questions, looks really good generally. very impressed!
Contributor
End-to-End Test ReportTest PreviewUnified Test Report grate harness
Cases
wasm harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Yaxuan-w
reviewed
Mar 11, 2026
| // Each sample run gets a fresh RawPOSIX lifecycle boundary to imitate actual | ||
| // behaviour. | ||
| rawposix_start(0); | ||
| let _ = execute_wasmtime(lindboot_cli.clone()); |
Member
There was a problem hiding this comment.
It shouldn't remove the exit handling
|
|
||
| let counters = perf::all_counter_names(); | ||
|
|
||
| // Iterate over all counters: |
Member
There was a problem hiding this comment.
Does the counter here mean how many loops we want to iterate? I'm a bit confused by this counter and the one in src/lind-perf/src/enabled/counter.rs
Member
There was a problem hiding this comment.
Even no-op still introduces overhead... I don't prefer we do in this way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lind-perf[base PR]Before merge: PRs #847 and #848 have this PR as their base, so merge those into
lind-perf-initbefore merging this branch to main.lind-perfimplementation.--features lind_perf+--perfflag)lind-boot.Changes:
lind-perfcontains the crate responsible for timing and reporting micro-benchmarks. This crate only performs timing related operations when built with theenabledfeature, otherwise every operation is a no-op. The dependency thus gets included regardless avoiding the excessive need forcfgflags in downstream crates.The
enabledfeature is wired tolind-boot'slind_perffeature.The logic and design decisions behind
lind-perfare explained in more detail in theREADME.mdand int the comments.lind-perf/disabled.rslind-perf/timers.rsCLOCK_MONOTONIC_RAWand theRDTSCtimers. (Only invoked whenenabled)lind-perf/enabled/The following changes were made to ensure these features are visible to
lind-boot:lind-boot/src/perf.rslind-boot/src/cli.rs--perfflag to enable performance runs.lind-boot/src/main.rs--perfruns.lind-boot/src/lind_wasmtime/trampoline.rslind-perfbased benchmark timers on a few hot paths.Dockerfile.e2elind-perfis included in the build.Example output from a performance run: