Merged
Conversation
Member
|
Okay, let's try to trade reviews with our peers too so you can all learn from each other. Maybe have @namanlalitnyu take a look first? I can do a review after. (Feel free to start on other calls / review other students' PRs in the meantime.) |
rennergade
reviewed
Jun 15, 2024
rennergade
reviewed
Jun 20, 2024
rennergade
requested changes
Jun 20, 2024
Contributor
rennergade
left a comment
There was a problem hiding this comment.
i think once you get the style updated this is ready to go!
rennergade
approved these changes
Jun 20, 2024
Contributor
rennergade
left a comment
There was a problem hiding this comment.
I think this is ready. Approved and great job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
The following changes include more elaborate comments and new unit tests for ioctl_syscall.
Type of change
How Has This Been Tested?
To run the tests, we need to run cargo test --lib command inside the safeposix-rust directory.
All the tests are present under this directory: lind_project/src/safeposix-rust/src/tests/fs_tests.rs
lut_lind_fs_ioctl_valid_args()ut_lind_fs_ioctl_invalid_args()Checklist: