Skip to content

Connect sys call comments and tests#277

Merged
rennergade merged 10 commits intodevelopfrom
connect-comment-branch
Jul 15, 2024
Merged

Connect sys call comments and tests#277
rennergade merged 10 commits intodevelopfrom
connect-comment-branch

Conversation

@davidge20
Copy link
Copy Markdown
Contributor

Description

Fixes # (issue)

All functions related to and including connect_syscall were commented out
A single test case was added to test out a UDP connection using the AF_INET6 address family. After feedback based on the correctness of the test, I will add more tests to the PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test A attempts to set up a UDP connection using the AF_INET6 address family. Currently, the test fails.
To reproduce run cargo test --lib command inside the safeposix-rust directory.

  • Test A - lind_project/src/safeposix-rust/src/tests/networking_tests.rs/ut_lind_net_connect_basic_udp_ipv6()

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, lind-project)

@davidge20 davidge20 requested a review from qianxichen233 June 25, 2024 19:08
@davidge20
Copy link
Copy Markdown
Contributor Author

@qianxichen233 Hi, I'm requesting your review for my PR

@davidge20 davidge20 requested a review from namanlalitnyu June 25, 2024 19:15
@davidge20
Copy link
Copy Markdown
Contributor Author

@namanlalitnyu Hi, requesting your review as well

Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/tests/networking_tests.rs Outdated
Comment thread src/tests/networking_tests.rs
@davidge20 davidge20 force-pushed the connect-comment-branch branch from a980fb7 to 13cd86c Compare July 10, 2024 19:57
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs
Comment thread src/safeposix/syscalls/net_calls.rs
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Copy link
Copy Markdown
Contributor

@rennergade rennergade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested several changes. Generally you need to flesh out the why a bit more.

Comment thread src/safeposix/syscalls/net_calls.rs
Copy link
Copy Markdown
Contributor

@rennergade rennergade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Approved.

@rennergade rennergade merged commit 588f7e8 into develop Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants