Connect sys call comments and tests#277
Merged
rennergade merged 10 commits intodevelopfrom Jul 15, 2024
Merged
Conversation
Contributor
Author
|
@qianxichen233 Hi, I'm requesting your review for my PR |
Contributor
Author
|
@namanlalitnyu Hi, requesting your review as well |
a980fb7 to
13cd86c
Compare
qianxichen233
approved these changes
Jul 12, 2024
rennergade
reviewed
Jul 12, 2024
rennergade
reviewed
Jul 12, 2024
rennergade
reviewed
Jul 12, 2024
rennergade
reviewed
Jul 12, 2024
rennergade
reviewed
Jul 12, 2024
rennergade
reviewed
Jul 12, 2024
rennergade
reviewed
Jul 12, 2024
rennergade
reviewed
Jul 12, 2024
rennergade
requested changes
Jul 12, 2024
Contributor
rennergade
left a comment
There was a problem hiding this comment.
Requested several changes. Generally you need to flesh out the why a bit more.
rennergade
reviewed
Jul 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
All functions related to and including connect_syscall were commented out
A single test case was added to test out a UDP connection using the AF_INET6 address family. After feedback based on the correctness of the test, I will add more tests to the PR.
Type of change
How Has This Been Tested?
Test A attempts to set up a UDP connection using the AF_INET6 address family. Currently, the test fails.
To reproduce run cargo test --lib command inside the safeposix-rust directory.
lind_project/src/safeposix-rust/src/tests/networking_tests.rs/ut_lind_net_connect_basic_udp_ipv6()Checklist: