Merged
Conversation
Contributor
|
@Anway-Agte can you review this before Rupesh does? |
Anway-Agte
suggested changes
Jun 30, 2024
Anway-Agte
approved these changes
Jul 1, 2024
added 2 commits
July 1, 2024 15:50
rennergade
reviewed
Jul 1, 2024
rennergade
requested changes
Jul 1, 2024
Contributor
rennergade
left a comment
There was a problem hiding this comment.
Minor comment about the EFAULT check. I also don't really know why there are so many extra files in this PR.
Otherwise really great job on this one, incredibly thorough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
The following changes include a small fix for checking null pointers, more elaborate comments, and new unit tests for
getcwd_syscall().Type of change
getcwd_syscall()bufargumentgetcwd_syscall()How Has This Been Tested?
To run the tests, we need to run cargo test --lib command inside the safeposix-rust directory.
All the tests are present under this directory: lind_project/src/safeposix-rust/src/tests/fs_tests.rs
lut_lind_fs_getcwd_valid_args()ut_lind_fs_getcwd_invalid_args()Checklist: