Merged
Conversation
Anway-Agte
requested review from
JustinCappos,
namanlalitnyu,
qianxichen233 and
rennergade
Contributor
|
@namanlalitnyu can you take a first look. |
Contributor
Reviewed and added some comments. |
Contributor
|
Mostly the changes look good to me! |
qianxichen233
approved these changes
Jul 3, 2024
Contributor
|
@rupeshkoushik07 can you review this? |
rupeshkoushik07
approved these changes
Jul 6, 2024
Member
rupeshkoushik07
left a comment
rupeshkoushik07
left a comment
There was a problem hiding this comment.
Comments and tests are on point. Resolve the conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The following changes include the tests and comments in the code for the
fork_syscallsystem callFixes # (issue)
Type of change
How Has This Been Tested?
All the test cases are in the sys_tests.rs file
ut_lind_fork()Checklist: