Merged
Conversation
Contributor
Author
|
@ve1nard can you please review my PR for link and unlink syscalls? |
Contributor
Author
|
@davidge20 can you please review this PR? |
ve1nard
reviewed
Jul 1, 2024
Contributor
ve1nard
left a comment
ve1nard
left a comment
There was a problem hiding this comment.
minor changes requested, great job overall
Contributor
|
@rupeshkoushik07 can you review this one |
davidge20
reviewed
Jul 1, 2024
yashaswi2000
reviewed
Jul 2, 2024
namanlalitnyu
requested review from
JustinCappos and
rennergade
and removed request for
rennergade
JustinCappos
requested changes
Jul 2, 2024
Member
JustinCappos
left a comment
JustinCappos
left a comment
There was a problem hiding this comment.
Looks pretty good. A few minor asks.
added 2 commits
July 3, 2024 19:41
JustinCappos
approved these changes
Jul 3, 2024
Member
JustinCappos
left a comment
JustinCappos
left a comment
There was a problem hiding this comment.
Thanks for the fixes. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
The following changes include the tests and comments in the code for the "link_syscall" and "unlink_syscall" file system calls under RustPosix.
The tests were added to cover all the possible scenarios that might happen when calling the file system_call
link_syscallandunlink_syscall.Type of change
How Has This Been Tested?
Inorder to run the tests, we need to run
cargo test --libcommand inside thesafeposix-rustdirectory.All the tests are present under this directory:
lind_project/src/safeposix-rust/src/tests/fs_tests.rsut_lind_fs_link_empty_path()ut_lind_fs_link_nonexistent_oldpath()ut_lind_fs_link_existing_newpath()ut_lind_fs_unlink_empty_path()ut_lind_fs_unlink_nonexistent_file()ut_lind_fs_unlink_root_directory()ut_lind_fs_unlink_directory()ut_lind_fs_unlink_success()ut_lind_fs_link_unlink_success()Checklist: