Update getdents_syscall tests and comments#286
Merged
rennergade merged 8 commits intodevelopfrom Jul 9, 2024
Merged
Conversation
qianxichen233
approved these changes
Jul 3, 2024
rennergade
reviewed
Jul 8, 2024
| let mut vec_filename: Vec<u8> = filename.as_bytes().to_vec(); | ||
| vec_filename.push(b'\0'); // make filename null-terminated | ||
|
|
||
| // Push DT_UNKNOWN as d_type. This is a placeholder for now, as the actual file type is not yet determined. |
Contributor
There was a problem hiding this comment.
some weird whitespace here, have you done a cargo fmt?
Member
Author
There was a problem hiding this comment.
yes even with cargo fmt the whitespace is there
rennergade
reviewed
Jul 8, 2024
Contributor
|
Some weird formatting things that I'd like you to take a quick look at but otherwise this is GTG |
Anway-Agte
pushed a commit
that referenced
this pull request
Jul 15, 2024
* add tests and comments * change sem comment * update * update comments * update tests * update format * update format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comments and tests to getdents_syscall
Type of change
How Has This Been Tested?
lind_project/tests/test_cases/test_a.clind_project/tests/test_cases/test_b.cChecklist: