Merged
Conversation
namanlalitnyu
commented
Jun 30, 2024
namanlalitnyu
commented
Jun 30, 2024
namanlalitnyu
commented
Jun 30, 2024
namanlalitnyu
requested review from
Anway-Agte and
rupeshkoushik07
and removed request for
rupeshkoushik07
Contributor
Author
|
@Anway-Agte @rupeshkoushik07 , please can you review these changes. |
Contributor
Author
|
@rennergade pls can you review this PR? |
rennergade
approved these changes
Jul 2, 2024
Contributor
rennergade
left a comment
rennergade
left a comment
There was a problem hiding this comment.
You need to fix a merge conflict but otherwise approved. Good job!
added 2 commits
July 2, 2024 18:20
Contributor
Author
Thanks Nick, I have resolved the merge conflicts. Can you please check once. |
Anway-Agte
reviewed
Jul 3, 2024
| /// * ENXIO - the file is of type UNIX domain socket | ||
| /// | ||
| /// A panic occurs when there is some issue fetching the file descriptor. | ||
| /// ### Panics |
Contributor
There was a problem hiding this comment.
Could you explain a bit more about the EINVAL and ENXIO errors?
| @@ -4488,8 +4550,8 @@ impl Cage { | |||
| drop(sementry); | |||
Contributor
There was a problem hiding this comment.
What does this sementry variable indicate?
| let fd = cage.creat_syscall(path, S_IRWXA); | ||
| assert!(fd > 0); | ||
|
|
||
| let mut statdata = StatData::default(); |
Contributor
There was a problem hiding this comment.
What is the StatData object?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
The following changes include the tests and comments in the code for the "creat_syscall" file system call under RustPosix.
The tests were added to cover all the possible scenarios that might happen when calling the file system_call
creat_syscall.Type of change
How Has This Been Tested?
Inorder to run the tests, we need to run
cargo test --libcommand inside thesafeposix-rustdirectory.All the tests are present under this directory:
lind_project/src/safeposix-rust/src/tests/fs_tests.rsut_lind_fs_creat_new_file()ut_lind_fs_creat_truncate_existing_file()Checklist: