Merged
Conversation
Contributor
namanlalitnyu
left a comment
namanlalitnyu
left a comment
There was a problem hiding this comment.
A few minor comments, but the changes look good. Great job!
Contributor
|
@rupeshkoushik07 can you take a look at this one? |
rupeshkoushik07
approved these changes
Jul 9, 2024
Member
rupeshkoushik07
left a comment
rupeshkoushik07
left a comment
There was a problem hiding this comment.
LGTM!
Please resolve the conflicts
rennergade
reviewed
Jul 9, 2024
rennergade
requested changes
Jul 9, 2024
Contributor
rennergade
left a comment
rennergade
left a comment
There was a problem hiding this comment.
Looks great, one minor change requested.
Anway-Agte
pushed a commit
that referenced
this pull request
Jul 15, 2024
* added a test for search permissions bug * updates syscall description * finished rmdir_syscall * bug fix * test changes * fixed everything * updated comments * fixed according to the review * performed cargo fmt * added a comment for close_helper_inner --------- Co-authored-by: lind <lind@nyu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
The following changes include new comments and unit tests for
rmdir_syscall(). Moreover, a fix of the bug related to write permission of a parent directory insidermdir_syscall()is proposed. In addition to that, a fix forlind_deltree()bug related to not setting a parent directory's write permission before iterating through child directories is included. Finally, the description for the bug related to the absence of checking search permission while walking the file tree is included in theut_lind_fs_search_permission_bug_with_rmdir()unit test. The issue (#283) for that bug has been opened as well.Type of change
rmdir_syscall()rmdir_syscall()rmdir_syscall()andlind_deltree()ut_lind_fs_search_permission_bug_with_rmdir()unit testHow Has This Been Tested?
To run the tests, we need to run cargo test --lib command inside the safeposix-rust directory.
All the tests are present under this directory: lind_project/src/safeposix-rust/src/tests/fs_tests.rs
ut_lind_fs_rmdir_normal()ut_lind_fs_rmdir_empty_path()ut_lind_fs_rmdir_nonexist_dir()ut_lind_fs_rmdir_root()ut_lind_fs_rmdir_nonempty_dir()ut_lind_fs_rmdir_nowriteperm_child_dir()ut_lind_fs_rmdir_nowriteperm_parent_dir()ut_lind_fs_search_permission_bug_with_rmdir()Checklist: