Merged
Conversation
davidge20
requested review from
Anway-Agte,
namanlalitnyu,
qianxichen233,
rennergade,
rupeshkoushik07,
ve1nard and
yashaswi2000
Contributor
Author
|
@ve1nard requesting your review, thanks |
davidge20
removed request for
Anway-Agte,
namanlalitnyu,
qianxichen233,
rennergade,
rupeshkoushik07 and
yashaswi2000
davidge20
commented
Jul 8, 2024
Contributor
|
@pranav-bhatt can you take a look at this one as well |
ve1nard
reviewed
Jul 12, 2024
davidge20
commented
Jul 15, 2024
Contributor
Author
|
@rupeshkoushik07 requesting your review, thanks! |
pranav-bhatt
approved these changes
Jul 16, 2024
davidge20
commented
Jul 16, 2024
Contributor
Author
|
@yashaswi2000 requesting your review, thanks! |
Contributor
yashaswi2000
left a comment
yashaswi2000
left a comment
There was a problem hiding this comment.
looks mostly good, we dont have any tests for this?
Contributor
Yeah we should test for common errors. I think there are enough tests for cases where this works but worth spending a few minutes brainstorming edge cases. |
rennergade
approved these changes
Jul 18, 2024
Anway-Agte
pushed a commit
that referenced
this pull request
Jul 18, 2024
* fn accept_unix commented * Final comments * updates based on pranav's and vlad's feedback * removed unnessecary comments * Added basic test to check for errors in accept sys call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
All functions related to and including accept_syscall were commented out
Type of change
How Has This Been Tested?
Will add test cases if necessary
Checklist: