Updates to "read_syscall" and "pread_syscall".#293
Merged
rennergade merged 9 commits intodevelopfrom Jul 11, 2024
Merged
Conversation
Contributor
Author
|
@ve1nard and @Anway-Agte, requesting your review of these changes. |
Anway-Agte
suggested changes
Jul 8, 2024
Anway-Agte
approved these changes
Jul 9, 2024
Contributor
Author
|
@yashaswi2000, Please can you review these changes. |
Contributor
yashaswi2000
left a comment
yashaswi2000
left a comment
There was a problem hiding this comment.
looks almost done. great job with the tests!
namanlalitnyu
force-pushed
the
naman_read
branch
from
1ae3a91 to
72dec29
Compare
namanlalitnyu
force-pushed
the
naman_read
branch
from
72dec29 to
84f7920
Compare
rennergade
reviewed
Jul 11, 2024
rennergade
reviewed
Jul 11, 2024
rennergade
reviewed
Jul 11, 2024
rennergade
requested changes
Jul 11, 2024
Contributor
rennergade
left a comment
rennergade
left a comment
There was a problem hiding this comment.
Some minor changes requested. Looks good!
Anway-Agte
pushed a commit
that referenced
this pull request
Jul 12, 2024
* Added comments for read, pread, _read_chr_file functions * Merge conflicts resolved * Added tests for read_syscall * Added tests for pread_syscall * reverted formatting changes for different file * Addressed review comments * Addressed review comments * Addressed review comments and added comments for a potential bug * Addressed review comments --------- Co-authored-by: lind <lind@nyu.edu>
Anway-Agte
pushed a commit
that referenced
this pull request
Jul 15, 2024
* Added comments for read, pread, _read_chr_file functions * Merge conflicts resolved * Added tests for read_syscall * Added tests for pread_syscall * reverted formatting changes for different file * Addressed review comments * Addressed review comments * Addressed review comments and added comments for a potential bug * Addressed review comments --------- Co-authored-by: lind <lind@nyu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
The following changes include the tests and comments in the code for the "read_syscall" and "pread_syscall" file system calls under RustPosix.
The tests were added to cover all the possible scenarios that might happen when calling the file system_calls
read_syscallandpread_syscall.Type of change
How Has This Been Tested?
Inorder to run the tests, we need to run
cargo test --libcommand inside thesafeposix-rustdirectory.All the tests are present under this directory:
lind_project/src/safeposix-rust/src/tests/fs_tests.rsut_lind_fs_read_write_only_fd()ut_lind_fs_read_from_directory()ut_lind_fs_read_from_epoll()ut_lind_fs_read_from_regular_file()ut_lind_fs_read_from_chardev_file()ut_lind_fs_read_from_sockets()ut_lind_fs_read_from_pipe_blocking_mode()ut_lind_fs_read_from_pipe_nonblocking_mode()ut_lind_fs_pread_write_only_fd()ut_lind_fs_pread_from_file()ut_lind_fs_pread_from_directory()ut_lind_fs_pread_invalid_types()Checklist: