chdir_syscall() and fchdir_syscall() updates#294
Merged
rennergade merged 12 commits intodevelopfrom Jul 13, 2024
Merged
Conversation
davidge20
reviewed
Jul 11, 2024
Contributor
davidge20
left a comment
davidge20
left a comment
There was a problem hiding this comment.
Great job overall! Great tests as well! Minor comments from my end
ve1nard
requested review from
rennergade and
yashaswi2000
and removed request for
yashaswi2000
rennergade
reviewed
Jul 12, 2024
rennergade
reviewed
Jul 12, 2024
Contributor
rennergade
left a comment
rennergade
left a comment
There was a problem hiding this comment.
This looks really good just want a few clarifications.
Contributor
yashaswi2000
left a comment
yashaswi2000
left a comment
There was a problem hiding this comment.
looks good. almost done.
added 2 commits
July 13, 2024 16:02
Anway-Agte
pushed a commit
that referenced
this pull request
Jul 15, 2024
* updated syscall description * removed refcount and finished the description * testing chdir * new tests for chdir and fchdir * formatted * removed decrementing refcount for cwd * fixed according to the review * merged develop and fixed typos * fixed according to the review --------- Co-authored-by: lind <lind@nyu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
The following changes more elaborate comments and new unit tests for
chdir_syscall()andfchdir_syscall().Type of change
chdir_syscall()andfchdir_syscall().chdir_syscall()andfchdir_syscall().How Has This Been Tested?
To run the tests, we need to run cargo test --lib command inside the safeposix-rust directory.
All the tests are present under this directory: lind_project/src/safeposix-rust/src/tests/fs_tests.rs
ut_lind_fs_chdir_valid_args()ut_lind_fs_chdir_removeddir()ut_lind_fs_chdir_invalid_args()ut_lind_fs_fchdir_valid_args()ut_lind_fs_fchdir_invalid_args()Checklist: