Added test and comments for poll_syscall#296
Merged
rennergade merged 5 commits intodevelopfrom Jul 17, 2024
Merged
Conversation
davidge20
reviewed
Jul 11, 2024
Contributor
davidge20
left a comment
There was a problem hiding this comment.
Great tests! Left some minor comments for more context and typos
Contributor
namanlalitnyu
left a comment
There was a problem hiding this comment.
Looks good to me, just two minor comments.
Very thorough tests!
namanlalitnyu
approved these changes
Jul 16, 2024
Contributor
|
LGTM! |
davidge20
approved these changes
Jul 16, 2024
yashaswi2000
approved these changes
Jul 17, 2024
Contributor
yashaswi2000
left a comment
There was a problem hiding this comment.
LGTM, really great job!
rennergade
reviewed
Jul 17, 2024
rennergade
requested changes
Jul 17, 2024
Contributor
rennergade
left a comment
There was a problem hiding this comment.
Minor comment but this is good to go. Great job!
rennergade
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR added several tests and comments for poll_syscall. The test being added is very simliar to select_syscall, as both syscalls serve a very similar purpose.
Fixes # (issue)
Several minor issues in poll_syscall are fixed in this PR:
Type of change
How Has This Been Tested?
ut_lind_net_poll_bad_inputut_lind_net_poll_timeoutut_lind_net_poll(this test is marked as ignore since an unfixed bug will panick the test)Checklist: