added tests and comments for epoll syscalls#297
Merged
rennergade merged 7 commits intodevelopfrom Jul 17, 2024
Merged
Conversation
ve1nard
reviewed
Jul 11, 2024
Contributor
namanlalitnyu
left a comment
There was a problem hiding this comment.
Some minor doubts related to the variables.
namanlalitnyu
approved these changes
Jul 13, 2024
Contributor
namanlalitnyu
left a comment
There was a problem hiding this comment.
Just one minor comment, but overall looks good!
Contributor
yashaswi2000
left a comment
There was a problem hiding this comment.
few minor comments, good job with the extensive tests
Contributor
Author
|
@yashaswi2000 just resolved these comments, could you check again? |
rennergade
reviewed
Jul 16, 2024
rennergade
requested changes
Jul 16, 2024
Contributor
rennergade
left a comment
There was a problem hiding this comment.
This is really thorough. Great job! One minor request.
rennergade
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR added some tests and comments for epoll related syscalls (epoll_create_syscall, epoll_ctl_syscall and epoll_wait_syscall).
Fixes # (issue)
Several minor issues in epoll are fixed in this PR:
maxeventsfds for readability/writability. E.g. if there are 10 file descriptors, and 5 of them are ready. Passing maxevents of 5 would cause epoll only monitors the first 5 file descriptor, and report for its readability/writability. Therefore, the number of ready fd could be less than 5. However, the correct behavior should be that epoll should always report first 5 ready file descriptor, in this case, its return value should always be 5.Type of change
How Has This Been Tested?
All the fixed behavior passed the test. (before the fix, it won't pass the test)
ut_lind_net_epoll_create_bad_inputut_lind_net_epoll_ctl_bad_inputut_lind_net_epoll_wait_bad_inputut_lind_net_epoll_maxevents_argut_lind_net_epoll_timeoutut_lind_net_epoll(this test is marked as ignore since an unfixed bug will panic the test)Checklist: