mmap_syscall() and munmap_syscall() updates#300
Merged
rennergade merged 9 commits intodevelopfrom Jul 15, 2024
Merged
Conversation
added 2 commits
July 11, 2024 23:19
Contributor
namanlalitnyu
left a comment
namanlalitnyu
left a comment
There was a problem hiding this comment.
Few minor changes, but looks good overall!
ve1nard
requested review from
rennergade and
yashaswi2000
and removed request for
qianxichen233 and
rennergade
rennergade
reviewed
Jul 14, 2024
rennergade
requested changes
Jul 14, 2024
Contributor
rennergade
left a comment
rennergade
left a comment
There was a problem hiding this comment.
this looks really good only had a minor revision
rennergade
approved these changes
Jul 15, 2024
Anway-Agte
pushed a commit
that referenced
this pull request
Jul 15, 2024
* finished mmap and munmap * removed whitespace * formatted * fixed the conditional * fixed the test * fixed according to the review * fixed the typo --------- Co-authored-by: lind <lind@nyu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
The following changes include more elaborate comments and new unit tests for
mmap_syscall()andmunmap_syscall().Type of change
mmap_syscall()andmunmap_syscall()mmap_syscall()andmunmap_syscall()How Has This Been Tested?
To run the tests, we need to run cargo test --lib command inside the safeposix-rust directory.
All the tests are present under this directory: lind_project/src/safeposix-rust/src/tests/fs_tests.rs
lut_lind_fs_mmap_zerolen()ut_lind_fs_mmap_invalid_flags_none()ut_lind_fs_mmap_invalid_flags_both()ut_lind_fs_mmap_no_read()ut_lind_fs_mmap_no_write()ut_lind_fs_mmap_invalid_offset_len()ut_lind_fs_mmap_chardev()ut_lind_fs_mmap_unsupported_file()ut_lind_fs_mmap_invalid_fildes()ut_lind_fs_munmap_zerolen()Checklist: