lseek_syscall and close_syscall updates#311
Merged
rennergade merged 8 commits intodevelopfrom Jul 26, 2024
Merged
Conversation
lseek_syscall and close_syscall updates
davidge20
reviewed
Jul 23, 2024
Contributor
davidge20
left a comment
There was a problem hiding this comment.
minor comments, overall great job explaining everything in detail!
Anway-Agte
reviewed
Jul 24, 2024
Contributor
Author
|
@davidge20 @Anway-Agte, I have addressed the review comments. Please can you review the changes once? |
Contributor
Author
|
@yashaswi2000, requesting your review of these changes. |
Anway-Agte
approved these changes
Jul 25, 2024
yashaswi2000
approved these changes
Jul 26, 2024
Contributor
yashaswi2000
left a comment
There was a problem hiding this comment.
Great Job, nice comments!
Contributor
Author
|
@rennergade, requesting your review of these changes. |
rennergade
reviewed
Jul 26, 2024
rennergade
requested changes
Jul 26, 2024
Contributor
rennergade
left a comment
There was a problem hiding this comment.
This looks quite good though the comment I pointed out is pretty major. I'd double check everything to be consistent with that.
eda0619 to
13fa126
Compare
rennergade
approved these changes
Jul 26, 2024
rupeshkoushik07
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
The following changes include the tests and comments in the code for the
lseek_syscallandclose_syscallfile system calls under RustPosix.The tests were added to cover all the possible scenarios that might happen when calling the file system_calls
lseek_syscallandclose_syscall.Type of change
How Has This Been Tested?
Inorder to run the tests, we need to run
cargo test --libcommand inside thesafeposix-rustdirectory.All the tests are present under this directory:
lind_project/src/safeposix-rust/src/tests/fs_tests.rsut_lind_fs_lseek_on_file()ut_lind_fs_lseek_on_directory()ut_lind_fs_lseek_invalid_whence()ut_lind_fs_lseek_beyond_file_size()ut_lind_fs_lseek_before_start_of_file()ut_lind_fs_lseek_on_pipe()ut_lind_fs_lseek_on_chardev()ut_lind_fs_lseek_on_epoll()ut_lind_fs_close_chardev()ut_lind_fs_close_pipe()ut_lind_fs_close_socket()ut_lind_fs_close_directory()ut_lind_fs_close_regular_file()Checklist: