Skip to content

Send, sendto, recv, recvfrom syscall comments and tests#314

Merged
rennergade merged 14 commits intodevelopfrom
send-comments
Aug 15, 2024
Merged

Send, sendto, recv, recvfrom syscall comments and tests#314
rennergade merged 14 commits intodevelopfrom
send-comments

Conversation

@davidge20
Copy link
Copy Markdown
Contributor

@davidge20 davidge20 commented Jul 18, 2024

Description

Commented send, sendto, recv, recvfrom syscalls.
Added basic tests to flag errors in send and ran exhaustive tests on unix sockets for sends/receives

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A - `ut_lind_net_recvfrom_unix()
  • Test B - 'ut_lind_net_send_close_server_socket_early()'
  • Test C - 'ut_lind_net_send_no_peer_address()'

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, lind-project)

Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
@rennergade rennergade requested a review from ve1nard July 19, 2024 15:07
Copy link
Copy Markdown
Contributor

@ve1nard ve1nard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small question

Comment thread src/safeposix/syscalls/net_calls.rs
Copy link
Copy Markdown
Contributor

@ve1nard ve1nard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rennergade rennergade requested a review from yashaswi2000 July 22, 2024 01:12
Copy link
Copy Markdown
Contributor

@yashaswi2000 yashaswi2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some questions for clarification

@qianxichen233 qianxichen233 self-requested a review July 25, 2024 03:16
Copy link
Copy Markdown
Contributor

@yashaswi2000 yashaswi2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rennergade rennergade requested a review from JustinCappos July 26, 2024 03:12
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs Outdated
Comment thread src/safeposix/syscalls/net_calls.rs
Comment thread src/tests/networking_tests.rs
@rennergade
Copy link
Copy Markdown
Contributor

@JustinCappos can you give David feedback so we can finalize this?

@rennergade rennergade merged commit 3d13034 into develop Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants