Send, sendto, recv, recvfrom syscall comments and tests#314
Merged
rennergade merged 14 commits intodevelopfrom Aug 15, 2024
Merged
Send, sendto, recv, recvfrom syscall comments and tests#314rennergade merged 14 commits intodevelopfrom
rennergade merged 14 commits intodevelopfrom
Conversation
Contributor
yashaswi2000
left a comment
There was a problem hiding this comment.
added some questions for clarification
qianxichen233
approved these changes
Jul 25, 2024
JustinCappos
requested changes
Jul 29, 2024
Contributor
|
@JustinCappos can you give David feedback so we can finalize this? |
rennergade
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Commented send, sendto, recv, recvfrom syscalls.
Added basic tests to flag errors in send and ran exhaustive tests on unix sockets for sends/receives
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist: