Skip to content

Description, Comments and tests for statfs_syscall & fstatfs_syscall#316

Merged
pranav-bhatt merged 2 commits intodevelopfrom
pb_doc_statfs_syscall
Jul 31, 2024
Merged

Description, Comments and tests for statfs_syscall & fstatfs_syscall#316
pranav-bhatt merged 2 commits intodevelopfrom
pb_doc_statfs_syscall

Conversation

@pranav-bhatt
Copy link
Copy Markdown
Contributor

Description

This PR adds comments and tests for the statfs_syscall & fstatfs_syscall system call function.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

For the unit tests added, run ``

  • Test A - safeposix-rust/tests/fs_tests.rs - ut_lind_fs_statfs_syscall_tests(),
  • Test B - safeposix-rust/tests/fs_tests.rs - ut_lind_fs_fstatfs_syscall_tests()

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, lind-project)

@pranav-bhatt pranav-bhatt marked this pull request as ready for review July 25, 2024 17:37
Copy link
Copy Markdown
Contributor

@ve1nard ve1nard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of comments

Comment thread src/safeposix/syscalls/fs_calls.rs Outdated
Comment thread src/safeposix/syscalls/fs_calls.rs
Comment thread src/tests/fs_tests.rs Outdated
Copy link
Copy Markdown
Contributor

@namanlalitnyu namanlalitnyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments.

Comment thread src/interface/types.rs Outdated
Comment thread src/safeposix/syscalls/fs_calls.rs
Comment thread src/tests/fs_tests.rs
@pranav-bhatt pranav-bhatt marked this pull request as draft July 27, 2024 07:06
@pranav-bhatt
Copy link
Copy Markdown
Contributor Author

@ve1nard @namanlalitnyu sorry for the confusion, this PR was branched off of another branch with stat calls. This one isnt ready to be reviewed yet but I accidentally marked it as ready

@pranav-bhatt pranav-bhatt force-pushed the pb_doc_statfs_syscall branch from 220b111 to 5711bca Compare July 28, 2024 08:18
@pranav-bhatt pranav-bhatt force-pushed the pb_doc_statfs_syscall branch from f7c16e3 to 5c774e0 Compare July 29, 2024 19:09
@pranav-bhatt pranav-bhatt marked this pull request as ready for review July 29, 2024 19:10
Copy link
Copy Markdown
Contributor

@namanlalitnyu namanlalitnyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rennergade rennergade requested a review from yashaswi2000 July 29, 2024 20:49
Copy link
Copy Markdown
Contributor

@ve1nard ve1nard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@yashaswi2000 yashaswi2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@rennergade rennergade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Looks great!

@pranav-bhatt pranav-bhatt merged commit ae72129 into develop Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants