Description, Comments and tests for statfs_syscall & fstatfs_syscall#316
Merged
pranav-bhatt merged 2 commits intodevelopfrom Jul 31, 2024
Merged
Description, Comments and tests for statfs_syscall & fstatfs_syscall#316pranav-bhatt merged 2 commits intodevelopfrom
statfs_syscall & fstatfs_syscall#316pranav-bhatt merged 2 commits intodevelopfrom
Conversation
ve1nard
reviewed
Jul 25, 2024
Contributor
namanlalitnyu
left a comment
There was a problem hiding this comment.
some minor comments.
Contributor
Author
|
@ve1nard @namanlalitnyu sorry for the confusion, this PR was branched off of another branch with stat calls. This one isnt ready to be reviewed yet but I accidentally marked it as ready |
220b111 to
5711bca
Compare
f7c16e3 to
5c774e0
Compare
rennergade
approved these changes
Jul 31, 2024
Contributor
rennergade
left a comment
There was a problem hiding this comment.
Approved. Looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comments and tests for the
statfs_syscall&fstatfs_syscallsystem call function.Type of change
How Has This Been Tested?
For the unit tests added, run ``
safeposix-rust/tests/fs_tests.rs - ut_lind_fs_statfs_syscall_tests(),safeposix-rust/tests/fs_tests.rs - ut_lind_fs_fstatfs_syscall_tests()Checklist: