Fix broken links in docs#4941
Merged
orbeckst merged 6 commits intoMDAnalysis:developfrom Mar 13, 2025
Merged
Conversation
Contributor
Author
|
Hi @micaela-matta and @orbeckst. Could you please review this PR? Thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4941 +/- ##
===========================================
- Coverage 93.66% 93.41% -0.26%
===========================================
Files 177 189 +12
Lines 21850 22925 +1075
Branches 3079 3078 -1
===========================================
+ Hits 20466 21415 +949
- Misses 933 1059 +126
Partials 451 451 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
orbeckst
requested changes
Mar 1, 2025
Member
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
THanks for the work. Minor comments inline.
Please also add yourself to AUTHORS.
Contributor
Author
|
Hi @orbeckst. Thanks for the comments. Only one change was needed at the end. |
IAlibay
requested changes
Mar 9, 2025
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
orbeckst
approved these changes
Mar 11, 2025
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Member
|
@IAlibay could you have a quick look again? Thank you for finding the correct AMBER pages. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Ah sorry, I saw you set auto-merge so I assumed you were dismissing my request changes. |
IAlibay
approved these changes
Mar 13, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Streamlining Documentation (SDG23)
Abdulrahman-PROG
pushed a commit
to Abdulrahman-PROG/mdanalysis
that referenced
this pull request
Apr 13, 2025
* Fixes MDAnalysis#4940 * Fix broken links * docs: address review comments * use new genuine AMBER TRJ specs * link to GMX current docs --------- Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4940
Changes made in this Pull Request:
Identified broken links in docs were fixed.
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--4941.org.readthedocs.build/en/4941/