Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4953 +/- ##
===========================================
- Coverage 93.68% 93.62% -0.06%
===========================================
Files 177 189 +12
Lines 21845 22923 +1078
Branches 3077 3077
===========================================
+ Hits 20465 21462 +997
- Misses 930 1011 +81
Partials 450 450 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "and will be removed in MDAnalysis version 3.0.0" | ||
| ) | ||
| warnings.warn(wmsg, category=DeprecationWarning) | ||
| try: |
There was a problem hiding this comment.
I'm not sure why these are reporting as not covered - the tests for both warnings seem to be passing.
There was a problem hiding this comment.
I manually tested everything locally (with and without the optional imports) so I'd say it's probably worth ignoring codecov here.
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Minor spelling fix for CHANGELOG as suggestion.
Docs (on RTD) do not include detailed code anymore (?) but they do have the link to the MDAKit and the deprecation note and that's good enough for me.
Co-authored-by: Oliver Beckstein <orbeckst@gmail.com>
Just checked the latest |
|
+1 for not duplicating documentation and tests. A link to a single source of truth is definitely the best approach. |
* mdakits are now optional deps --------- Co-authored-by: Oliver Beckstein <orbeckst@gmail.com>
3 participants
Fixes #4899
Changes made in this Pull Request:
PR Checklist
package/CHANGELOGfile updated?Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.