-
Notifications
You must be signed in to change notification settings - Fork 830
Update ResidueGroup/SegmentGroup with ids (PDBParser: force chainid to segid / Universe: set groups) #4965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
orbeckst
merged 48 commits into
MDAnalysis:develop
from
yuyuan871111:pdbparser_chainid_segid
Apr 16, 2025
Merged
Update ResidueGroup/SegmentGroup with ids (PDBParser: force chainid to segid / Universe: set groups) #4965
Changes from 4 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
48a20d4
add feature: force_chainids_to_segids to PDBParser
yuyuan871111 1039838
Merge branch 'MDAnalysis:develop' into develop
yuyuan871111 a86a184
PDBParser segid column 73-76
yuyuan871111 01d5c8d
update authors and document for PDB
yuyuan871111 e2707e4
add warning, test function, format to flake8 with darker and black
yuyuan871111 c2e0765
update document
yuyuan871111 4e638e2
Merge branch 'develop' into pdbparser_chainid_segid
yuyuan871111 9472cf5
update doc
yuyuan871111 c9afea7
guess segments by ids
yuyuan871111 806f514
fix the import conflict
yuyuan871111 3247dae
fix typo and dtype
yuyuan871111 4fe0a4c
update doc and test
yuyuan871111 861928a
cover more codes with tests and fix bugs
yuyuan871111 18b7e85
add warnings, change to set_groups to make it easy understand
yuyuan871111 141fd4c
test_set_groups: add test for atoms.resids
yuyuan871111 ee64ffc
update doc
yuyuan871111 da9b84f
increase test coverage
yuyuan871111 efba1f3
update the docs and simplify the codes
yuyuan871111 a594aaf
Merge branch 'develop' into pdbparser_chainid_segid
yuyuan871111 729c00a
fix with code review
yuyuan871111 c43a115
fix with code review
yuyuan871111 9dca86a
fix typos
yuyuan871111 324a51e
Merge branch 'develop' into pdbparser_chainid_segid
yuyuan871111 42261eb
Merge branch 'develop' into pdbparser_chainid_segid
yuyuan871111 93d38c8
formatting
yuyuan871111 96ac6f5
PDB note less
yuyuan871111 51eaa80
update with code review and update doc
yuyuan871111 4797dea
fix test fails, move force_segids_to_chainids test from coordinates's…
yuyuan871111 c8941ac
Update universe.py
yuyuan871111 f9f3aa1
remove redundant 'else'
yuyuan871111 31c7796
fix bug in test
yuyuan871111 9be6f99
replacefor loop with assert_equal
yuyuan871111 3d822f7
add CHANGELOG
yuyuan871111 9c438a4
Merge branch 'develop' into pdbparser_chainid_segid
yuyuan871111 82b8c98
update docs
yuyuan871111 83d009d
update docs
yuyuan871111 f4f5228
Update package/MDAnalysis/topology/PDBParser.py
yuyuan871111 c0fd273
fix with review
yuyuan871111 ba66fdb
add test in test_pdb
yuyuan871111 eaf052c
fix typo
yuyuan871111 f3d2eaf
enhance test coverage
yuyuan871111 6b61cd9
more general version for set groups
yuyuan871111 d4a4a3f
prune redundant codes in pdbparser
yuyuan871111 44e659b
add test no affect customattrs
yuyuan871111 060b3ef
add test no affect customattrs
yuyuan871111 de73b17
Merge branch 'develop' into pdbparser_chainid_segid
orbeckst dd47aa8
Update testsuite/MDAnalysisTests/core/test_universe.py
yuyuan871111 d1dbade
Merge branch 'develop' into pdbparser_chainid_segid
yuyuan871111 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.