Implementing Numpy Performance Improvements for Array Copying#4987
Merged
tylerjereddy merged 2 commits intoMDAnalysis:developfrom Mar 21, 2025
Merged
Implementing Numpy Performance Improvements for Array Copying#4987tylerjereddy merged 2 commits intoMDAnalysis:developfrom
tylerjereddy merged 2 commits intoMDAnalysis:developfrom
Conversation
added 2 commits
March 21, 2025 04:58
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4987 +/- ##
===========================================
- Coverage 93.42% 93.41% -0.02%
===========================================
Files 177 189 +12
Lines 21859 22925 +1066
Branches 3078 3078
===========================================
+ Hits 20422 21415 +993
- Misses 986 1059 +73
Partials 451 451 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmacdope
approved these changes
Mar 21, 2025
tylerjereddy
approved these changes
Mar 21, 2025
Member
tylerjereddy
left a comment
tylerjereddy
left a comment
There was a problem hiding this comment.
Seems a bit borderline that it is worth the churn, but I agree it is probably slightly more efficient.
Abdulrahman-PROG
pushed a commit
to Abdulrahman-PROG/mdanalysis
that referenced
this pull request
Apr 13, 2025
…ysis#4987) * faster array copying --------- Co-authored-by: Lexi Xu <you@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2063
Changes made in this Pull Request:
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--4987.org.readthedocs.build/en/4987/