Conversation
Fixed capitalizations in MD package names
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5020 +/- ##
===========================================
+ Coverage 93.42% 93.61% +0.19%
===========================================
Files 177 177
Lines 21865 21907 +42
Branches 3079 3100 +21
===========================================
+ Hits 20427 20508 +81
+ Misses 986 946 -40
- Partials 452 453 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
orbeckst
left a comment
There was a problem hiding this comment.
As a first-time contributor, please add yourself to AUTHORS and add your GH handle to CHANGELOG. (You don't need an entry for the fix in CHANGELOG.)
|
Please resolve the conflicts by putting your name at the end in each case. Thanks. |
|
I'll just remove my name from CHANGELOG and AUTHORS bcz I'm already adding them in #5007 |
|
We will not merge this PR unless at the point of merging the names are there or you state in the PR comments that you don't want your names to be put in the CHANGELOG and AUTHORS for the PR. So if you want to ensure that your names show up, I'd put them in. If you don't care, please say so explicitly. |
orbeckst
left a comment
There was a problem hiding this comment.
With your other PR merged, you're now in AUTHORS and CHANGELOG.
Fixed capitalizations in MD package names
Changes made in this Pull Request:
PR Checklist
[ ] Issue raised/referenced?[ ] Tests updated/added?[ ]package/CHANGELOGfile updated?[ ] Is your name inpackage/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5020.org.readthedocs.build/en/5020/