Skip to content

Update README.rst#5020

Merged
orbeckst merged 5 commits intoMDAnalysis:developfrom
tulga-rdn:patch-1
Apr 18, 2025
Merged

Update README.rst#5020
orbeckst merged 5 commits intoMDAnalysis:developfrom
tulga-rdn:patch-1

Conversation

@tulga-rdn
Copy link
Copy Markdown
Contributor

@tulga-rdn tulga-rdn commented Apr 8, 2025

Fixed capitalizations in MD package names

Changes made in this Pull Request:

  • TSIA, changed capitalization of GROMACS, DL_POLY and HOOMD

PR Checklist

  • [ ] Issue raised/referenced?
  • [ ] Tests updated/added?
  • Documentation updated/added?
  • [ ] package/CHANGELOG file updated?
  • [ ] Is your name in package/AUTHORS? (If it is not, add it!)

Developers Certificate of Origin

I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.


📚 Documentation preview 📚: https://mdanalysis--5020.org.readthedocs.build/en/5020/

Fixed capitalizations in MD package names
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.61%. Comparing base (7fb3534) to head (45dd864).
Report is 21 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5020      +/-   ##
===========================================
+ Coverage    93.42%   93.61%   +0.19%     
===========================================
  Files          177      177              
  Lines        21865    21907      +42     
  Branches      3079     3100      +21     
===========================================
+ Hits         20427    20508      +81     
+ Misses         986      946      -40     
- Partials       452      453       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure :-) – thanks

@orbeckst orbeckst self-assigned this Apr 11, 2025
Copy link
Copy Markdown
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a first-time contributor, please add yourself to AUTHORS and add your GH handle to CHANGELOG. (You don't need an entry for the fix in CHANGELOG.)

@orbeckst
Copy link
Copy Markdown
Member

Please resolve the conflicts by putting your name at the end in each case. Thanks.

@tulga-rdn
Copy link
Copy Markdown
Contributor Author

I'll just remove my name from CHANGELOG and AUTHORS bcz I'm already adding them in #5007

@orbeckst
Copy link
Copy Markdown
Member

We will not merge this PR unless at the point of merging the names are there or you state in the PR comments that you don't want your names to be put in the CHANGELOG and AUTHORS for the PR.

So if you want to ensure that your names show up, I'd put them in. If you don't care, please say so explicitly.

Copy link
Copy Markdown
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With your other PR merged, you're now in AUTHORS and CHANGELOG.

@orbeckst orbeckst merged commit af9848b into MDAnalysis:develop Apr 18, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants