forked from bvaughn/scheduling-profiler-prototype
-
Notifications
You must be signed in to change notification settings - Fork 0
Remove schedulerCanvasHeight #39
Copy link
Copy link
Closed
Labels
importance: 2 - should haveThis should be implemented, but we will still have a working product if we don'tThis should be implemented, but we will still have a working product if we don'tphase: 2 - iterationIterations on our MVPIterations on our MVPurgency: 4 - no urgencyWe have an indefinite amount of time to complete thisWe have an indefinite amount of time to complete thiswork type: investigationA task that primarily involves digging into a particular problemA task that primarily involves digging into a particular problem
Metadata
Metadata
Assignees
Labels
importance: 2 - should haveThis should be implemented, but we will still have a working product if we don'tThis should be implemented, but we will still have a working product if we don'tphase: 2 - iterationIterations on our MVPIterations on our MVPurgency: 4 - no urgencyWe have an indefinite amount of time to complete thisWe have an indefinite amount of time to complete thiswork type: investigationA task that primarily involves digging into a particular problemA task that primarily involves digging into a particular problem
schedulerCanvasHeightis currently being computed inAppand passed toCanvasPage. This is problematic for the following reasons:should not be aware ofAutoSizedCanvas's andrenderCanvas`'s implementation detailsschedulerCanvasHeightis insufficient forAutoSizedCanvas's use case.schedulerCanvasHeightis passed to bothusePanAndZoomandgetHoveredEvent. In Brian's design, the scheduler canvas area only contained the 4 priority rows, and this height made sense. However, in the new design with separate event row and measure lanes,getHoveredEventneeds to know the heights of the events row and the measure lanes separately, butusePanAndZoomstill requires the total height.schedulerCanvasHeightshould be removed from App and replaced with another approach. Ideally, we should somehow use the definitive calculations fromrenderCanvas.