Skip to content

Remove schedulerCanvasHeight #39

@taneliang

Description

@taneliang

schedulerCanvasHeight is currently being computed in App and passed to CanvasPage. This is problematic for the following reasons:

  1. 'Appshould not be aware ofAutoSizedCanvas's and renderCanvas`'s implementation details
  2. schedulerCanvasHeight is insufficient for AutoSizedCanvas's use case. schedulerCanvasHeight is passed to both usePanAndZoom and getHoveredEvent. In Brian's design, the scheduler canvas area only contained the 4 priority rows, and this height made sense. However, in the new design with separate event row and measure lanes, getHoveredEvent needs to know the heights of the events row and the measure lanes separately, but usePanAndZoom still requires the total height.

schedulerCanvasHeight should be removed from App and replaced with another approach. Ideally, we should somehow use the definitive calculations from renderCanvas.

Metadata

Metadata

Assignees

Labels

importance: 2 - should haveThis should be implemented, but we will still have a working product if we don'tphase: 2 - iterationIterations on our MVPurgency: 4 - no urgencyWe have an indefinite amount of time to complete thiswork type: investigationA task that primarily involves digging into a particular problem

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions