Skip to content

[Improve base View][1/n] Add subview handling to View#99

Merged
taneliang merged 1 commit intomasterfrom
5f2da-0
Aug 3, 2020
Merged

[Improve base View][1/n] Add subview handling to View#99
taneliang merged 1 commit intomasterfrom
5f2da-0

Conversation

@taneliang
Copy link
Copy Markdown
Member

@taneliang taneliang commented Jul 30, 2020

Stack PR by STACK ATTACK:

Stacked on #96.

Summary

This PR begins a stack of PRs that improves the base View class
implemented in #80.

This PR adds subview management to View, as there was a lot of
duplicated subview handling code present in almost all our View
subclasses. This also brings us closer to UIKit's UIView, which
also handles its own subviews.

Resolves #95.

Test Plan

  • yarn start: nothing broken
  • yarn lint
  • yarn flow: no errors in affected code
  • yarn test

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/h5ssiarea
✅ Preview: https://scheduling-profiler-prototype-git-5f2da-0.mlh-fellowship.vercel.app

Summary

This PR begins a stack of PRs that improves the base `View` class
implemented in #80.

This PR adds subview management to `View`, as there was a lot of
duplicated subview handling code present in almost all our `View`
subclasses. This also brings us closer to UIKit's `UIView`, which
also handles its own subviews.

Implements #95.

Test Plan

* `yarn start`: nothing broken
* `yarn lint`
* `yarn flow`: no errors in affected code
* `yarn test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Views: Support subviews in View class

2 participants