Skip to content

Speed up _create_topic_vectors by replacing DataFrame .loc with NumPy masking#2406

Merged
MaartenGr merged 3 commits intoMaartenGr:masterfrom
jinsolp:efficient-create-topic-vec
Aug 17, 2025
Merged

Speed up _create_topic_vectors by replacing DataFrame .loc with NumPy masking#2406
MaartenGr merged 3 commits intoMaartenGr:masterfrom
jinsolp:efficient-create-topic-vec

Conversation

@jinsolp
Copy link
Copy Markdown
Contributor

@jinsolp jinsolp commented Aug 5, 2025

What does this PR do?

Fixes #2405

Before submitting

  • This PR fixes a typo or improves the docs (if yes, ignore all other checks!).
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes (if applicable)?
  • Did you write any new necessary tests?

@MaartenGr
Copy link
Copy Markdown
Owner

Awesome, I like the elegant implementation. LGTM!

@MaartenGr MaartenGr merged commit 6669201 into MaartenGr:master Aug 17, 2025
6 checks passed
@jinsolp jinsolp deleted the efficient-create-topic-vec branch August 18, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve efficiency of _create_topic_vectors for loop

2 participants