CI maintenance: 3 failing runs on PR #32 — fixes ready in PRs #33 and #34, recommend merge plan

[erudenko]

Summary

Automated CI maintenance scan (2026-05-02) found 3 actively failing workflow runs, all on the fix/ci-workflow-trigger-broadening branch (PR #32). The fixes already exist and are fully green in PRs #33 and #34 — this issue documents the failures, their root causes, and the recommended merge path.

---

Failing runs

Run ID	Workflow	Job	Branch	Status
24298790072	Test Plugins	test (20)	fix/ci-workflow-trigger-broadening	❌ FAILURE
24298790072	Test Plugins	test (22)	fix/ci-workflow-trigger-broadening	❌ CANCELLED
24298790076	Test Stats Plugin	test	fix/ci-workflow-trigger-broadening	❌ FAILURE
24298782547	Test Stats Plugin	test	fix/ci-workflow-trigger-broadening	❌ FAILURE

---

Root causes

1. Unused TypeScript imports (TS6133) — Test Plugins failure

tsc --noEmit fails under noUnusedLocals for three imports left behind after refactors:

File	Unused import
tools/claudeup-core/src/__tests__/integration/conventions-integration.test.ts	removeGitignoreEntries
tools/claudeup-core/src/__tests__/unit/doctor.test.ts	vi
tools/claudeup-core/src/services/conventions-manager.ts	existsSync

PR #32 only changed workflow trigger YAML — it was stacked on fix/ci-type-errors-and-stale-test-date, which still had these broken imports.

2. Stale hardcoded test date — Test Stats Plugin failure

plugins/stats/tests/integration.test.ts uses hardcoded date "2026-03-26" as the default in makeSession(). As of today (2026-05-02) that date is 37 days ago, well outside the 7-day and 14-day rolling query windows used by:

• getSessionSummary returns correct averages and totals (7-day window → 0 rows → assertion fails)
• getTopTools returns tools ranked by call count (7-day window → 0 rows → assertion fails)
• getDurationTrend returns daily data in ASC date order (14-day window → 0 rows → assertion fails)

---

Current CI status of all open PRs

PR	Branch	CI result	Notes
#34	fix/ci-all-fixes-final	✅ 13/13 green	Most complete fix; covers integration.test.ts dates
#33	fix/ci-consolidated	✅ 7/7 green	Comprehensive; adds workflow trigger broadening
#32	fix/ci-workflow-trigger-broadening	❌ 3 failures	Superseded by #33
#31	fix/ci-main-browser-use-version	⚠️ Only GitGuardian	main is dist-only orphan; test workflows don't exist there
#28	fix/ci-24276607217-browser-use-version	⚠️ Only GitGuardian	Superseded by #24 (branch filter blocked CI)
#24	fix/ci-24065489776-ts-and-dates	✅ 7/7 green	All code-level fixes; base for #33
#23	fix/ci-typescript-and-stats-dates-resolved	⚠️ Only GitGuardian	Superseded by #24
#22	fix/ci-typescript-and-stats-dates	⚠️ Only GitGuardian	Superseded by #24

---

Recommended merge plan

All code-level fixes are already written and green. No new code is needed. The remaining work is merging in the right order:

1. Merge PR fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers #33 (fix/ci-consolidated → fix/ci-type-errors-and-stale-test-date)

   • All 7 checks green (last verified 2026-04-12)
   • Fixes: TS unused imports, stale stats dates, browser-use version mismatch, workflow trigger broadening
   • This resolves the root cause of all 3 failing runs listed above

2. Merge PR fix(ci): complete all-fixes branch — rolling stats dates in integration.test.ts + browser-use 1.1.2 #34 if integration.test.ts date fixes from that PR are not already in fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers #33

   • All 13 checks green
   • Adds TODAY/YESTERDAY/TWO_DAYS_AGO constants to integration.test.ts

3. Close as superseded: PRs fix(ci): remove hardcoded branch filters from workflow triggers #32, fix(marketplace): bump browser-use version 1.1.1 → 1.1.2 in marketplace.json #28, fix(ci): resolve merge conflict — unused TS imports + stale stats test dates #23, fix(ci): remove unused TS imports + fix stale stats test dates #22 — their changes are a subset of what's already in fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers #33/fix(ci): complete all-fixes branch — rolling stats dates in integration.test.ts + browser-use 1.1.2 #34

4. Consider closing PR fix(marketplace): bump browser-use version 1.1.1 → 1.1.2 to fix CI #31 — main is a dist-only orphan branch; the workflow files don't exist there and test CI can never run. If marketplace.json needs updating on main, it should come from an automated dist publish step, not a manual PR.

---

Why no new fix branch was created

The failing runs (24298790072 / 24298790076 / 24298782547) are on an old branch that is already superseded. Creating another fix branch would add to the accumulation of open fix PRs without resolving the underlying issue, which is that the existing green fix PRs (#33, #34) have not yet been merged.

https://claude.ai/code/session_01EcJqpj1mQ5kZAi14MD5aUg