Skip to content

CI maintenance: 3 failed runs on PR #32 (superseded by #33) + stale PR cleanup needed #46

@erudenko

Description

@erudenko

Summary

Automated CI audit (2026-04-14) found 3 recent test failures on PR #32 (fix/ci-workflow-trigger-broadening). These failures are real code bugs, not transient — but they are already fully fixed in PR #33 (fix/ci-consolidated), which is 100% green. No new fix branch is needed.

The main action required is: merge the green PRs in order and close the stale ones.


Failed Runs

Run ID Workflow Job Conclusion
24298790072 Test Plugins test (20) failure
24298790072 Test Plugins test (22) cancelled (after test(20) failed)
24298790076 Test Stats Plugin test failure
24298782547 Test Stats Plugin test failure

All on branch fix/ci-workflow-trigger-broadening (PR #32).

Root Cause

PR #32 only changed the workflow YAML to broaden CI triggers — it did not fix the underlying code bugs. When CI started running on that branch, it exposed:

  1. Unused TypeScript imports (TS6133)tsc --noEmit fails under noUnusedLocals:

    • conventions-integration.test.ts: removeGitignoreEntries
    • doctor.test.ts: vi
    • conventions-manager.ts: existsSync
  2. Stale hardcoded test datesplugins/stats/tests/integration.test.ts still used "2026-03-26" as the default date in makeSession(). Three time-windowed tests (getSessionSummary, getTopTools, getDurationTrend) return 0 rows because that date is now 17–19 days outside their 7/14-day query windows.

  3. browser-use version mismatchmarketplace.json still at 1.1.1 while plugin.json is at 1.1.2, causing the marketplace-sync integration test to fail.


Current PR Landscape

PR Branch CI Status
#24 fix/ci-24065489776-ts-and-dates ✅ All green Foundational fix — TS imports, stale dates, browser-use version, trigger broadening for its base
#33 fix/ci-consolidated ✅ All green Recommended merge target — supersedes #22, #23, #28, #32; based on #24 head + removes all branch filters
#34 fix/ci-all-fixes-final ✅ All green Addresses integration.test.ts stale dates + browser-use version (also covered by #33)
#32 fix/ci-workflow-trigger-broadening ❌ Failing Superseded by #33 — close this PR
#31 fix/ci-main-browser-use-version ⚪ No test CI Targets dist-only main; test workflows don't exist there — close
#28 fix/ci-24276607217-browser-use-version ⚪ No test CI Branch excluded by old trigger filter; superseded by #24/#33 — close
#23 fix/ci-typescript-and-stats-dates-resolved ⚪ No test CI Superseded by #24 — close
#22 fix/ci-typescript-and-stats-dates ⚪ No test CI Superseded by #24 — close

Recommended Actions

  1. Merge PR fix(ci): remove 3 unused TS imports + fix stale stats dates + re-enable CI triggers #24 — clean foundational fix, all green, smallest diff. Since fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers #33 is based on fix(ci): remove 3 unused TS imports + fix stale stats dates + re-enable CI triggers #24's head, fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers #33's diff will shrink automatically after this merge.
  2. Merge PR fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers #33 — after fix(ci): remove 3 unused TS imports + fix stale stats dates + re-enable CI triggers #24 lands, this adds the full trigger broadening (removes branch filters from both workflow files) plus picks up all remaining fixes. Supersedes everything below.
  3. Close PRs fix(ci): remove unused TS imports + fix stale stats test dates #22, fix(ci): resolve merge conflict — unused TS imports + stale stats test dates #23, fix(marketplace): bump browser-use version 1.1.1 → 1.1.2 in marketplace.json #28, fix(marketplace): bump browser-use version 1.1.1 → 1.1.2 to fix CI #31, fix(ci): remove hardcoded branch filters from workflow triggers #32 as superseded/not_planned.
  4. Assess PR fix(ci): complete all-fixes branch — rolling stats dates in integration.test.ts + browser-use 1.1.2 #34 — if fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers #33 already contains integration.test.ts rolling-date fix and browser-use 1.1.2 (it does, per the PR body), fix(ci): complete all-fixes branch — rolling stats dates in integration.test.ts + browser-use 1.1.2 #34 may also be closeable after fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers #33 merges.
  5. Assess PR feat: improve skill scores for 5 lowest-scoring skills #15 (external skill improvement from rohan-tessl) — unrelated to CI; review on its own merits.

Filed by automated CI maintenance agent. No new fix branch was created because the fixes already exist in green PRs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingci

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions