Skip to content

ci: CI audit — 3 active failures on PR #32, all addressed by PR #33 (recommend merge path) #47

@erudenko

Description

@erudenko

CI Audit — 2026-04-14

This issue was created by an automated CI maintenance agent after auditing recent GitHub Actions failures. The gh CLI was unavailable, so check runs were inspected via the GitHub API.


Failed Runs Found

All active CI failures are on PR #32 (fix/ci-workflow-trigger-broadening), branch pushed on 2026-04-12:

Run ID Job Conclusion Workflow
24298790072 test (20) failure test-plugins.yml
24298790072 test (22) cancelled test-plugins.yml
24298790076 test failure test-stats.yml
24298782547 test failure test-stats.yml

Root Causes

PR #32 only added the workflow trigger fix (removing branches allowlists from test-plugins.yml and test-stats.yml). It was based on fix/ci-type-errors-and-stale-test-date, which still carries the unresolved code bugs:

  1. Stale hardcoded dates in plugins/stats/tests/integration.test.ts
    The test's makeSession() default date was "2026-03-26", now 17+ days ago — outside the 7-day and 14-day rolling query windows used by getSessionSummary, getTopTools, and getDurationTrend. Those tests assert length > 0 and return zero rows.

  2. Unused TypeScript imports (TS6133)tsc --noEmit fails under noUnusedLocals:

    • conventions-integration.test.ts: removeGitignoreEntries
    • doctor.test.ts: vi
    • conventions-manager.ts: existsSync

When CI finally ran on PR #32 (because the trigger fix worked), the underlying code bugs caused the tests to fail immediately.


Current State of Open Fix PRs

PR Branch CI Fixes
#33 fix/ci-consolidated ✅ all green (7/7) TS imports + stale dates + browser-use version + unrestricted workflow triggers — most complete
#34 fix/ci-all-fixes-final ✅ all green (13/13) integration.test.ts dates + browser-use version
#24 fix/ci-24065489776-ts-and-dates ✅ all green (7/7) TS imports + stale dates + browser-use version + partial trigger fix
#32 fix/ci-workflow-trigger-broadening ❌ 3 failures Trigger fix only (without code fixes) — superseded by #33
#31 fix/ci-main-browser-use-version GitGuardian only Targets main (orphan dist branch — no workflows there)
#28 fix/ci-24276607217-browser-use-version GitGuardian only browser-use only — superseded
#23 fix/ci-typescript-and-stats-dates-resolved GitGuardian only TS + dates — superseded
#22 fix/ci-typescript-and-stats-dates GitGuardian only TS + dates — superseded

PRs #22, #23, #28, #31 had no test CI run because of the branches allowlist bug those PRs were meant to fix — a chicken-and-egg problem that #33 resolves.


Recommended Actions

  1. Merge PR fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers #33 (fix/ci-consolidated) — it is the single most complete fix, all CI green, and consolidates every outstanding failure into one PR. After merging into fix/ci-type-errors-and-stale-test-date, the source branch will be fully green.

  2. Close as superseded: PRs fix(ci): remove hardcoded branch filters from workflow triggers #32, fix(ci): complete all-fixes branch — rolling stats dates in integration.test.ts + browser-use 1.1.2 #34, fix(marketplace): bump browser-use version 1.1.1 → 1.1.2 in marketplace.json #28, fix(ci): resolve merge conflict — unused TS imports + stale stats test dates #23, fix(ci): remove unused TS imports + fix stale stats test dates #22 (all address a subset of what fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers #33 covers, or have failing CI).

  3. Close PR fix(marketplace): bump browser-use version 1.1.1 → 1.1.2 to fix CI #31 — it targets main (the dist-only orphan branch). No test workflow files exist on main, so CI can never run there. The actual fix needs to land on the source branch via fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers #33.

  4. Consider PR fix(ci): remove 3 unused TS imports + fix stale stats dates + re-enable CI triggers #24 — it is also fully green and a good base if fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers #33 is not preferred. fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers #33 is built on top of fix(ci): remove 3 unused TS imports + fix stale stats dates + re-enable CI triggers #24's head and adds only the workflow trigger broadening commit.


Why No New Fix Branch Was Created

All three root-cause failures are fully addressed by PR #33 with passing CI. Creating a new fix/ci-<run-id> branch would duplicate existing work and further clutter the open-PR list. The right action is to merge the correct existing PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingci

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions